-
Notifications
You must be signed in to change notification settings - Fork 33
Gcp/service/gke backup #279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Migrated 52 policy files from monolithic to modular helpers - Added new modular helper system in policies/_helpers/ - Created comprehensive test inputs for all policies - Fixed OPA evaluation errors with duplicate function definitions - Implemented all 6 resource types with proper validations
docs/gcp/Backup_for_GKE/resource_json/gke_backup_backup_channel.json
Outdated
Show resolved
Hide resolved
policies/gcp/backup_for_gke/backup_channel/bandwidth/policy.rego
Outdated
Show resolved
Hide resolved
policies/gcp/backup_for_gke/backup_channel/destination_project/policy.rego
Show resolved
Hide resolved
policies/gcp/backup_for_gke/restore_plan_iam_binding/domain_access/policy.rego
Show resolved
Hide resolved
policies/gcp/backup_for_gke/restore_plan_iam_binding/personal_emails/policy.rego
Show resolved
Hide resolved
policies/gcp/backup_for_gke/restore_plan_iam_binding/public_access/policy.rego
Show resolved
Hide resolved
policies/gcp/backup_for_gke/restore_plan_iam_binding/service_accounts/policy.rego
Show resolved
Hide resolved
|
@Tikster123 Reviewed your responses to the PR comments. Please note that custom functions are not permitted in PDE policies as they do not follow the accepted PDE format. |
Hi Shanika, i have replaced the auto_test.py to its original format and also made sure the custom roles are not present and that my policies follow the correct format thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the new PR comments, resolve and resubmit. Also, please make sure that you merge latest update from the dev branch to resolve any merge conflicts.
policies/gcp/backup_for_gke/backup_plan/description/policy.rego
Outdated
Show resolved
Hide resolved
made the necessary changes by deleting the files and also merged the latest updates from the dev branch, Thank you so much for your time Shanika! |
Shani1116
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved all PR comments. Approved!

No description provided.