Created service for GCP App Engine #271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shani1116
requested changes
Jan 23, 2026
Contributor
Shani1116
left a comment
Shani1116
left a comment
There was a problem hiding this comment.
- Solid policies. Good work. There is scope to add additional policies for google_app_engine_flexible_app_version and google_app_engine_standard_app_version, but given the size of this service, the current set of policies is sufficient.
- Service documentation is missing. For more info - https://github.com/Hardhat-Enterprises/Policy-Deployment-Engine/blob/dev/scripts/docgen/README.md
policies/gcp/app_engine/app_engine_application/database_type/policy.rego
Outdated
Show resolved
Hide resolved
policies/gcp/app_engine/app_engine_application/database_type/policy.rego
Show resolved
Hide resolved
policies/gcp/app_engine/app_engine_flexible_app_version/liveness_check/path/policy.rego
Show resolved
Hide resolved
policies/gcp/app_engine/app_engine_flexible_app_version/readiness_check/path/policy.rego
Show resolved
Hide resolved
policies/gcp/app_engine/app_engine_domain_mapping/ssl_settings/ssl_management_type/policy.rego
Show resolved
Hide resolved
Shani1116
approved these changes
Feb 4, 2026
Contributor
Shani1116
left a comment
Shani1116
left a comment
There was a problem hiding this comment.
Resolved all PR comments. Approved!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.