Skip to content

docs: a pod over the namespace quota fails its execution - #440

Merged
HardMax71 merged 1 commit into
mainfrom
max/policies-doc-pod-failure
Oct 22, 2026
Merged

HardMax71 merged 1 commit into
mainfrom
max/policies-doc-pod-failure

Conversation

@HardMax71

@HardMax71 HardMax71 commented Oct 22, 2026 •

Copy link
Copy Markdown
Owner

Summary

The security policies page said the worker publishes pod_creation_failed when the namespace quota refuses a pod. #428 removed that event, so the sentence pointed at something that no longer exists (policies.md).

Changes

The sentence now says what happens: the execution scheduler stores the execution as failed with error type system_error (execution_scheduler.py).

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Refactoring (no functional changes)
  • CI/CD or tooling changes

Test Plan

  • Backend unit tests pass (cd backend && uv run pytest tests/unit)
  • Frontend unit tests pass (cd frontend && npm run test)
  • Backend E2E tests pass (docker compose exec -T backend sh -c 'uv sync --group test --no-dev --frozen --no-install-project --no-build && pytest tests/e2e')
  • Frontend E2E tests pass (cd frontend && npm run test:e2e)
  • API spec and client regenerated if routes or schemas changed (./deploy.sh openapi, then ./deploy.sh types), never edited by hand
  • Manual testing performed

Validation: docs only; CI's docs build checks it.

Checklist

  • My code follows the project's style guidelines
  • I have run pre-commit run --all-files and all checks pass
  • I have added tests that prove my fix/feature works
  • I have updated documentation if needed
  • My changes don't introduce new warnings

Summary by cubic

Fixes the security policies docs, which claimed the worker publishes pod_creation_failed when a pod is refused by the namespace quota. Since #428 removed that event, the docs now state what actually happens: the execution scheduler records the execution as failed with error type system_error.

Written for commit e37dea7. Summary will update on new commits.

View guided diff Turn on auto-fix

…n_failed no longer exists

#428 removed the event, and the security policies page still named it.
@HardMax71
HardMax71 enabled auto-merge (squash) October 22, 2026 11:49
@coderabbitai

coderabbitai Bot commented Oct 22, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d641f950-5dc5-487f-a5e5-37a3285283f4
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Oct 22, 2026
@HardMax71
HardMax71 merged commit 3a82f36 into main Oct 22, 2026
20 checks passed
@HardMax71
HardMax71 deleted the max/policies-doc-pod-failure branch October 22, 2026 11:49
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant