Skip to content

deps: pydantic brings its own pydantic-core, so the direct pin goes - #429

Merged
HardMax71 merged 1 commit into
mainfrom
deps/drop-pydantic-core-pin
Oct 20, 2026
Merged

HardMax71 merged 1 commit into
mainfrom
deps/drop-pydantic-core-pin

Conversation

@HardMax71

@HardMax71 HardMax71 commented Oct 20, 2026 •

Copy link
Copy Markdown
Owner

Summary

The Dependabot update for uv in /backend fails on every run (39336898284, 39321368884) with dependency_file_not_resolvable for both pydantic and pydantic-core. pyproject pins pydantic==2.14.0 and pydantic_core==2.50.0, pydantic 2.14.1 requires pydantic-core==2.50.1 (PyPI), and Dependabot bumps the two one at a time, so neither update can resolve. pydantic stays stuck at 2.14.0.

Changes

The direct pydantic_core pin goes. Nothing imports pydantic_core, and pydantic pins it exactly, so the lock keeps pydantic-core 2.50.0 and the next Dependabot run moves both together. The pin came from the pip to uv move in #7, which copied a frozen requirements.txt into pyproject.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Refactoring (no functional changes)
  • CI/CD or tooling changes

Test Plan

  • Backend unit tests pass (cd backend && uv run pytest tests/unit)
  • Frontend unit tests pass (cd frontend && npm run test)
  • Backend E2E tests pass (docker compose exec -T backend sh -c 'uv sync --group test --no-dev --frozen --no-install-project --no-build && pytest tests/e2e')
  • Frontend E2E tests pass (cd frontend && npm run test:e2e)
  • API spec and client regenerated if routes or schemas changed (./deploy.sh openapi, then ./deploy.sh types), never edited by hand
  • Manual testing performed

Validation: uv lock changes only the two lines of the pin, uv lock --check passes, the synced env has pydantic 2.14.0 with pydantic-core 2.50.0, and 545 unit tests and mypy --strict pass.

Checklist

  • My code follows the project's style guidelines
  • I have run pre-commit run --all-files and all checks pass
  • I have added tests that prove my fix/feature works
  • I have updated documentation if needed
  • My changes don't introduce new warnings

Summary by cubic

Removes the direct pydantic_core pin so Dependabot can update pydantic and pydantic-core together.

backend/pyproject.toml pinned pydantic==2.14.0 and pydantic_core==2.50.0, but Dependabot bumps the two one at a time, so neither update could resolve and every run failed. Nothing imports pydantic_core directly, and pydantic pins its exact version, so the lock keeps pydantic-core 2.50.0 and the next run resolves both together.

Written for commit 217ca39. Summary will update on new commits.

View guided diff Turn on auto-fix

pydantic pins pydantic-core exactly, and Dependabot bumps the two one at a
time, so neither update resolved. The lock keeps pydantic-core 2.50.0.
@HardMax71
HardMax71 enabled auto-merge (squash) October 20, 2026 22:30
@coderabbitai

coderabbitai Bot commented Oct 20, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: da8045bb-e92f-4385-98ad-9d960addd9d1
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@codecov-commenter

codecov-commenter commented Oct 20, 2026 •

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Flag Coverage Δ
backend-e2e 83.04% <ø> (-0.10%) ⬇️
backend-unit 75.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Backend 93.15% <ø> (ø)
Frontend 92.12% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@HardMax71
HardMax71 merged commit 25a8853 into main Oct 20, 2026
25 checks passed
@HardMax71
HardMax71 deleted the deps/drop-pydantic-core-pin branch October 20, 2026 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants