Repository navigation
test: the DLQ repository tests delete the rows they insert - #418
Merged
Merged
Conversation
HardMax71
enabled auto-merge (squash)
October 19, 2026 21:44
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Small bug found while checking the DLQ span metrics. Two tests in test_dlq_repository.py insert DLQ rows on topics
t1andt2and never delete them. After one e2e run the shared database kept 6 of them, so the worker's DLQ size job reportst1= 3 andt2= 1 until the 7-day TTL runs out.Changes
The inserts become fixtures that yield and then delete their rows by event id, the way
failed_eventintests/e2e/dlq/test_dlq_manager.pyalready does.Type of Change
Test Plan
cd backend && uv run pytest tests/unit)cd frontend && npm run test)docker compose exec -T backend sh -c 'uv sync --group test --no-dev --frozen --no-install-project --no-build && pytest tests/e2e')cd frontend && npm run test:e2e)./deploy.sh openapi, then./deploy.sh types), never edited by handValidation: ruff and mypy --strict pass; the Backend E2E job runs both tests against the real stack.
Checklist
pre-commit run --all-filesand all checks passSummary by cubic
Fixes the DLQ repository e2e tests leaving inserted rows behind, which inflated the worker's DLQ size job metrics for topics
t1andt2until the 7-day TTL expired.test_dlq_manager.py.Written for commit 6e2b9cb. Summary will update on new commits.