Repository navigation
fix: OS package upgrades run on every image build, so Trivy stops failing on fixes the cache hid - #417
Merged
Conversation
…ling on fixes the cache hid
HardMax71
enabled auto-merge (squash)
October 19, 2026 21:11
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Docker Scan & Promote has failed on every
maincommit since at least 7dbe76f (latest run), solateststopped moving and the nightly release has found nothing new since 2026.10.27 (bcbf249, Oct 14). The backend image carrieslibcurl4t64 8.14.1-2+deb13u5with three HIGH CVEs (CVE-2026-92392, CVE-2026-8927, CVE-2026-8286) thatdeb13u7fixes. The Dockerfile does runapt-get upgrade, but in thebasestage, and CI restores that stage from its tarball cache and the GHA layer cache, so the upgrade layer is the one from whenever it was first built.Changes
The backend upgrades its OS packages in its last stage, which CI builds fresh every run, and the
basestage no longer does. The frontend's stage is namedproduction, and CI builds it withno-cache-filters: production, so itsapk upgradecan't go stale the same way.Type of Change
Test Plan
cd backend && uv run pytest tests/unit)cd frontend && npm run test)docker compose exec -T backend sh -c 'uv sync --group test --no-dev --frozen --no-install-project --no-build && pytest tests/e2e')cd frontend && npm run test:e2e)./deploy.sh openapi, then./deploy.sh types), never edited by handValidation: built the backend the CI way on the stale published
base:latest(libcurl4t64 deb13u5); the result hasdeb13u7. The scan itself runs after this merges, in Docker Scan & Promote.Checklist
pre-commit run --all-filesand all checks passSummary by cubic
Fixes Docker Scan & Promote failing on every
maincommit by moving OS package upgrades to build layers CI never caches, so security fixes released after a cached build (like the backend image'slibcurl4t64HIGH CVEs) actually land in the published images.basestage no longer runsapt-get upgrade; a new step in the final stage, which CI builds fresh every run, does.productionand CI builds it withno-cache-filters: production, so itsapk upgradecan't go stale.docs/security/supply-chain.mdto describe the new caching behavior.Written for commit 28443bf. Summary will update on new commits.