fix(trash-cleanup): never clean grids hosting worldloaders#1661
Draft
Kronyxxx wants to merge 3 commits intoHardLightSector:masterfrom
Draft
fix(trash-cleanup): never clean grids hosting worldloaders#1661Kronyxxx wants to merge 3 commits intoHardLightSector:masterfrom
Kronyxxx wants to merge 3 commits intoHardLightSector:masterfrom
Conversation
ShadesMars
suggested changes
May 6, 2026
Contributor
ShadesMars
left a comment
There was a problem hiding this comment.
If doing this way, delete CleanupProtectedGridComponent as its not usefull.
Worldloader can also be disabled in a variable, so lets not have two comp that does the same.
Collaborator
Author
|
still a draft lol yeah |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a safety guard to trash cleanup so infrastructure grids that host world loaders are never deleted by distance-based cleanup.
Problem
Trash cleanup currently protects loader-adjacent grids indirectly via protection zones calculated from world loader positions. If those assumptions drift or a loader edge case occurs, a critical loader-hosting grid can still become cleanup-eligible.
Solution
Add a direct guard in
ShouldProtectGrid():WorldLoaderComponent, treat it as protected and skip cleanup.Files Changed
Content.Server/Trash/TrashCleanupSystem.csBehavior Impact
Risk
Low.
WorldLoaderComponent.Validation
Related