Fix intermittent station job payout drops#1556
Open
Kronyxxx wants to merge 2 commits intoHardLightSector:masterfrom
Open
Fix intermittent station job payout drops#1556Kronyxxx wants to merge 2 commits intoHardLightSector:masterfrom
Kronyxxx wants to merge 2 commits intoHardLightSector:masterfrom
Conversation
…er_override_rules
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- keep station pay scheduling synchronized when minds move between entities (MindAdded/MindRemoved on tracked jobs)\n- make payout attempts return success/failure and only advance the schedule when the payout actually succeeds\n- avoid silently dropping a pay interval when an eligible job is temporarily unattached\n\n## Root cause\n- station pay scheduling only listened to role add/remove, which does not fire on mind transfer between bodies\n- payout schedule entries could stay on the old entity after transfer and then fail deposits\n- update loop always advanced schedule even when deposit failed, permanently dropping that tick\n\n## Validation\n- dotnet build Content.Server/Content.Server.csproj (succeeds; warnings only)