Check implieds on debug #6120
Open
Check implieds on debug #6120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@Pepper0ni what do you think of having implied logic included like normal without any comment or wrapping function? |
Contributor
|
Implied stuff is usually done as minor optimisations, on ship it probably doesn't make a big difference and most likely need unrolling for enemy souls anyway as most are some variant of "an enemy dies the same way as you get the check". I'd have to double check there's no serious issues, otherwise it's just making sure we aren't making things hell for AP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of just having implied things on comments, check them on debug to avoid issues where the comments get out of date or someone makes a change without taking them into account.
Build Artifacts