ImGui-Driven Extraction Flow and Progress Reporting #5892
Conversation
Add extraction, argument, and verification steps. Remove commented menubar code.
|
This is now undrafted, but I'm adding |
…n and just revert back to PS_FIRST popup. Re-add ROM search in new flow. Move port archive checking to ImGui with default fonts.
Malkierian
force-pushed
the
imgui-extract
branch
from
c6baddb to
866a91e
Compare
Add extra information to extraction modal. Add PS_FILE_CHECK step.
|
On Linux it's hanging on extract of |
|
There is no extraction of soh.o2r. It's supposed to exit. |
& then it sits. No window appears |
|
I may need you to debug this on Linux. It's virtually impossible to tell where exactly it's hanging just with that log. |
|
After fixing extractStep, when I click |
Does this occur with ROMs in the folder, without them there, or both? |
|
Nevermind, I think I found it. |
|
Oh, right, since this also holds a LUS bump, I think #6121 is unnecessary (since that's only a LUS bump). |
confirmed file dialog opens, stuck in |
Are you sure? It takes like 15 seconds to start the progress bar even on release. Probably takes longer in debug. |
|
had left it for about half an hour, & I'm on a pretty beefy machine |
|
Well, I don't know what's going on with that, then, as I just tested it locally and it was fine. Probably something in the thread dispatching or the setup for ZAPD. |
|
ZAPD is throwing caused because |
|
Well then fill it, lol. That's supposed to be setup with the setup command, isn't it? |
|
I created it when I got error message |
|
My point is that the assets folder is supposed to be created and filled in setup or build or something. That has nothing to do with the functionality of the code at this point. |
|
extraction working now, needed to run |
Sure, but better error messages or having error handling show error messages when human involved is being stupid would be good |
serprex
left a comment
serprex
left a comment
There was a problem hiding this comment.
works for me, could use exception handling
Extract filename from file path for display in extraction progress. Fix searchPath not being set in PS_LOCAL. Improve newlining for text to better fit default window.
2 participants
This sets up the initialization process to allow for producing an ImGui window before ROM archives are made, so that ImGui can be used to prompt users along the O2R creation process instead of using the OS prompts, which aren't always usable even on some Linux devices, let alone other 2nd-party port platforms, as well as graphically report extraction progress.
devenv_M8mo7jT32R.mp4
Requires HarbourMasters/ZAPDTR#33 and Kenix3/libultraship#949
TODO:
Build Artifacts