Custom items: initial support code #5669
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On some distros format-security is turned on to detect possible issues with non-string literals as format strings Let's explicitly turn it on and fix the ImgUi text formatting to avoid compile issues on those platforms Signed-off-by: William Casarin <[email protected]>
This is a safe wrapper around the icon table so that we don't immediately crash when we try to use an id that isn't expected Signed-off-by: William Casarin <[email protected]>
When creating custom items, let's not immediately crash if trying to lookup an unknown item action for a new id Signed-off-by: William Casarin <[email protected]>
When creating custom items, have a fallback slot for custom item ids that don't have an entry in the itemId -> slot mapping table Signed-off-by: William Casarin <[email protected]>
Contributor
Contributor
|
I've handled everything that was required for Roc's. This would protect against crashes but properly implemented items shouldn't hit any of these failsafes to begin with. It's also directly replacing source code which I'm not super jazzed about. I would like to know what the actual purpose of this is. I understand that the plan is to ultimately have other systems to introduce custom items, but the payoff here feels questionable to me. |
Contributor
|
@jb55 could you split out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are a few minimal commits to stop the application from outright crashing when creating custom items.
The main reason this is needed is there are a few places in the codebase that map item ids to icons, slots, and item actions. Since these are fixed sized tables, custom ids fall outside the range of these tables and then it crashes. These are non-behavior-modifying changes to these lookups so that custom ids work.
The plan is to a have a dynamic hook-based approach for creating new items on the fly without touching the upstream code too much.
Unfortunately still builds on:
since I need that to compile