[Enhancement] Disable Magic Drops with Chateau #1424
Conversation
|
This is nice, a simpler implementation of the junk items customization PR I'll probably never finish lol |
|
Maybe make this option a combobox? I personally have reservations about making recovery hearts spawn more often, so I'd prefer spawning green Rupees instead. But some people may have different preferences. |
What are your reservations out of curiosity? |
Just that it makes it easier to get hearts. That inherently makes the game even easier than infinite magic alone. |
Added a TODO for it. |
Just added it, fyi |
Eblo
left a comment
Eblo
left a comment
There was a problem hiding this comment.
Not to scope creep, moreso food for thought: any reason to have these two hard options? The Chateau situation is a little specific. It might be better to just have a generic toggle that handles random drops based on the player's status. I realize that starts to overlap with the junk customization options PR, though this PR differs in that it applies to vanilla and non-shuffled item drops. At the very least, I would appreciate being able to substitute magic drops with arrows if I'm Chateau'd lol
If your answer invalidates some of my feedback, then feel free to disregard said feedback.
| "Off", | ||
| "Recovery Heart", | ||
| "Green Rupee", |
There was a problem hiding this comment.
| "Off", | |
| "Recovery Heart", | |
| "Green Rupee", | |
| "Off", // DISABLE_MAGIC_DROPS_OFF | |
| "Recovery Heart", // DISABLE_MAGIC_DROPS_RECOVERY_HEART, | |
| "Green Rupee", // DISABLE_MAGIC_DROPS_GREEN_RUPEE |
| // dropId | ||
| // ``` | ||
| // #### `args` | ||
| // - `s16*` (dropId) |
There was a problem hiding this comment.
| // - `s16*` (dropId) | |
| // - `*s16` (dropId) |
| } | ||
|
|
||
| s16 func_800A7650(s16 dropId) { | ||
| GameInteractor_Should(VB_ITEM00_GET_DROP_ID, true, &dropId); |
There was a problem hiding this comment.
While I know you're not directly pre-empting vanilla behavior in the enhancement, maybe this should wrap everything before the final return.
I wanna make sure I'm interpreting your feedback correctly. What is your vision? Give me the big picture. |
4 participants
This simply switches out the item drops to be recovery hearts if the player has drank the Chateau. An additional benefit of this, is that if the player is at max health the vanilla logic will switch the recovery heart out for a rupee instead.
This is a potential solution to #1406
TODO
Add support for a rupees only option per Jordan's request.Build Artifacts