Skip to content

Conversation

@Eblo
Copy link
Contributor

@Eblo Eblo commented Nov 21, 2025

Unlike OoT, MM's rolls have damage flags at the end, which allows for destroying pots and grass. This was achieved by changing collision flags during certain frames in a roll. However, the flags are directly assigned instead of OR'd, meaning that if a collision occurs during this phase of the roll (which sets OC1_HIT), it will be cleared before it is checked. In effect, trees reached at the end of a roll are not bonked and are moreso slid around instead.

This enhancement changes the damage collision to be OR'd instead, which makes tree bonks feel more OoT-like while maintaining the damaging properties of rolls. This restoration will go well with #1346

Build Artifacts

@Caladius
Copy link
Contributor

Tested this out, this feels identical to OoT. Bonking trees from a distance is now much more consistent.

@Eblo Eblo merged commit 8c75b33 into HarbourMasters:develop Nov 23, 2025
5 checks passed
@Eblo Eblo deleted the bonk-collision-fix branch November 23, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants