[Enhancement] Restore OoT tree bonk behavior #1354
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike OoT, MM's rolls have damage flags at the end, which allows for destroying pots and grass. This was achieved by changing collision flags during certain frames in a roll. However, the flags are directly assigned instead of OR'd, meaning that if a collision occurs during this phase of the roll (which sets
OC1_HIT), it will be cleared before it is checked. In effect, trees reached at the end of a roll are not bonked and are moreso slid around instead.This enhancement changes the damage collision to be OR'd instead, which makes tree bonks feel more OoT-like while maintaining the damaging properties of rolls. This restoration will go well with #1346
Build Artifacts