Implement sarias song hint item #1161
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mckinlee
reviewed
Jul 16, 2025
Contributor
mckinlee
left a comment
mckinlee
left a comment
There was a problem hiding this comment.
Just a few questions for ya.
Comment on lines
+15
to
+18
| std::set<RandoItemId> progressiveItems = { | ||
| RI_BOW, RI_HOOKSHOT, RI_MASK_BLAST, RI_BOMB_BAG_20, RI_MASK_DEKU, RI_MASK_GORON, | ||
| RI_MASK_ZORA, RI_MASK_FIERCE_DEITY, RI_SONG_SONATA, RI_SONG_LULLABY, RI_SONG_NOVA, RI_SONG_SOARING, | ||
| }; |
Contributor
There was a problem hiding this comment.
Could we do a lookup of all RITYPE_MAJOR and RITYPE_MASK items? Or are you wanting to handpick these?
| } | ||
| } | ||
|
|
||
| return progressiveChecks.empty() ? RC_UNKNOWN : progressiveChecks[0]; |
Contributor
There was a problem hiding this comment.
Is it your preference that its item 0 in the set? My thought is make it random.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Saria's Song to the pool, which is a one time use item that gives a guaranteed progressive item hint that is currently reachable in logic.
This has been sitting on a branch for a while, PRing it to give it a nudge, maybe someone can do a pass on the progression lookup it's not very thorough. There's also a source code change I need to convert to a hook
video preview on discord
Build Artifacts