Use antibody liability modality for nanobody/antibody protocols instead of peptide default#229
Open
chr-wn wants to merge 1 commit into
Open
Use antibody liability modality for nanobody/antibody protocols instead of peptide default#229chr-wn wants to merge 1 commit into
chr-wn wants to merge 1 commit into
Conversation
…ad of peptide default
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raised in issue #228
The
nanobody-anythingandantibody-anythingprotocols inherited defaultliability_modality: peptide(from analysis.yaml), so liability analysis scored designed CDRs against peptide rules instead of antibody ones. I just addedliability_modality=antibodyto both protocols' analysis overrides inprotocol_configsso the correct panel is produced by default. There isn't an explicit statement that this is intended, but it makes the most sense to use antibody rules for antibody runs. Users can still override with--config analysis liability_modality=....