Fix atom_to_token remapping for variable insertions in visibility=1 scaffolds, respect defined structure_groups visibility and constraint validation for file entities, and CIF writer#155
Open
cmoscy wants to merge 2 commits into
Conversation
added 2 commits
January 13, 2026 12:43
… bugs - structure_groups: respect visibility value for id: "all" - constraints: validate file entity chains and fix missing raise statements - CIF writer: use manual counter instead of unreliable loop.length()
… Remap indices after filtering
cmoscy
changed the title
cmoscy
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! Couple things that come up when working with file-based templates, constraints, etc.
pr155-changes.md