fix: exclude log rule from general scanning to prevent duplicates#19
Merged
fix: exclude log rule from general scanning to prevent duplicates#19
Conversation
Resolves #17 - Double-up of items found The R080LogContainsSecret rule was being included in the general rules list, causing it to run on all files during regular and environment file scanning, not just log files. This resulted in: 1. Duplicate detections of the same secret on the same line 2. Non-log files incorrectly labeled as "Secret in log" 3. Files like googlecloud.json being scanned multiple times by different rules, creating separate findings with different contexts Changes: - Removed R080LogContainsSecret from get_all_rules() return list - Added documentation explaining why it's excluded - The rule is now only used by scanner._scan_logs() for actual log files This ensures the log rule only runs on log files via the dedicated log scanner, significantly reducing duplicate findings and preventing misleading "Secret in log" labels on non-log files. Co-authored-by: HallyAus <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #17 - Double-up of items found
The R080LogContainsSecret rule was being included in the general rules list, causing it to run on all files during regular and environment file scanning, not just log files. This resulted in:
Changes:
This ensures the log rule only runs on log files via the dedicated log scanner, significantly reducing duplicate findings and preventing misleading "Secret in log" labels on non-log files.