Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapped the DeskNoteTextView into a BScrollView (should fix #12) #23

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jsteinaker
Copy link

-When resizing the view, the space obtained is now used to show any extra lines the note may have.
-When deleting lines, the view now scrolls back to the right place.

If one or two people can try this it would be great, seems to be working here.

@humdingerb
Copy link
Member

This appears to have killed the context menu.
And I cannot make scrollbars appear... What are steps to produce those?
Plus, what's the problem being solved with those scrollbars? Without this PR, the text gets line-broken and flows back when resizing the window and deleting lines seems to work OK, too.

I also agree with what you wrote in #18, scrollbars don't quite fit the post-it idea of small notes. Nicer would be to implement linking to other documents that would open in their preferred apps.

@jsteinaker
Copy link
Author

You're right with the context menu. Fixed, thanks for spotting that!

Bug solved is described on #12, steps to reproduce are on the first two comments (two different ways). About the scrollbars: I don't want them! I was expecting them because that is what BScrollView is supposed to do, but I'm 100% happy with the view scrolling properly this way. Give it a try again, if anything, the view scrolls more "naturally" this way.

Thanks for testing!

@humdingerb
Copy link
Member

OK, I looked at #18 and wasn't sure what's the issue...
I agree, works nicely now. Go on and merge, and close #18 as 'won't fix'. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants