Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: help buttons targeting a not found page #2422

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sad270
Copy link

@sad270 sad270 commented Apr 2, 2025

The help button in Settings > PHP > Symfony > Method References is targeting https://espend.de/phpstorm/plugin/symfonyextension/method_parameter.html

The help button in Settings > PHP > Symfony > Type Provider is targeting https://espend.de/phpstorm/plugin/symfonyextension/signature_type.html

And both url are 404 Not found.

In this MR we replace url by those targeting PHPStorm documentation (the new documentation) https://www.jetbrains.com/help/phpstorm/symfony-support.html

As HELP_URL is only used on settings main page I remove the constant to replace it by a string. (Tell me if it's good for you)

I also change the buttonHelp label by Project Page / Documentation as it's not the Help page anymore. But the project Page and this project page contains documentation like. (I use the same wording we can found on plugin page here https://plugins.jetbrains.com/plugin/7219-symfony-support to be consistent)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant