fix: help buttons targeting a not found page #2422
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
help
button inSettings > PHP > Symfony > Method References
is targetinghttps://espend.de/phpstorm/plugin/symfonyextension/method_parameter.html
The
help
button inSettings > PHP > Symfony > Type Provider
is targetinghttps://espend.de/phpstorm/plugin/symfonyextension/signature_type.html
And both url are 404 Not found.
In this MR we replace url by those targeting PHPStorm documentation (the new documentation) https://www.jetbrains.com/help/phpstorm/symfony-support.html
As
HELP_URL
is only used on settings main page I remove the constant to replace it by a string. (Tell me if it's good for you)I also change the
buttonHelp
label byProject Page / Documentation
as it's not the Help page anymore. But the project Page and this project page contains documentation like. (I use the same wording we can found on plugin page here https://plugins.jetbrains.com/plugin/7219-symfony-support to be consistent)