Skip to content
This repository was archived by the owner on May 22, 2020. It is now read-only.

Conversation

@yongjich
Copy link

@yongjich yongjich commented Oct 17, 2019

Add process.versions.chrome to System.getRuntimeInfo

Link to test:
https://testing-dashboard.openfin.co/#/app/tests/5da87d4dee166d7a14d45189/edit

Link to js-adapter PR:
HadoukenIO/js-adapter#368

Checklist

Release Notes

Notes:

@finos-admin
Copy link

Thank you for your pull request and welcome to our community! We require contributors to sign a Contributor License Agreement and we don't seem to have CLAs on file for these contributors to the Pull Request: (@yongjich). In order for your PR to be reviewed and merged, please follow the directions at the link above.

Project team: please do not merge this Pull Request until Foundation staff have confirmed that a CLA is in place for the new contributor(s) listed above.

If there are any questions, please don't hesitate to get in touch with our Infrastructure Support team. /CC @finos-admin

@yongjich yongjich changed the title RUN-5683 add process.versions.chrome to getRuntimeInfo RUN-5683 Add process.versions.chrome to getRuntimeInfo Oct 17, 2019
@yongjich yongjich changed the title RUN-5683 Add process.versions.chrome to getRuntimeInfo [RUN-5683] Add process.versions.chrome to getRuntimeInfo Oct 17, 2019
Copy link
Contributor

@pbaize pbaize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Can we add a js-adapter pr for the types and maybe test the value in test runner by comparing against userAgent? https://stackoverflow.com/questions/4900436/how-to-detect-the-installed-chrome-version

@openfin-github-bot openfin-github-bot bot added the auto testing started Bot started automated testing label Oct 17, 2019
@yongjich
Copy link
Author

Code looks good. Can we add a js-adapter pr for the types and maybe test the value in test runner by comparing against userAgent? https://stackoverflow.com/questions/4900436/how-to-detect-the-installed-chrome-version

Okay. Included js-adapter pr and updated test-runner test to compare against userAgent

@openfin-github-bot
Copy link

954cfe7

Git

  • core: develop <= RUN-5683-getRuntimeInfo (954cfe7)
  • js-adapter: develop
  • javascript-adapter: develop

Asars used for testing

Test results

@openfin-github-bot openfin-github-bot bot added auto testing done Bot completed automated testing and removed auto testing started Bot started automated testing labels Oct 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

auto testing done Bot completed automated testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants