Skip to content

project: node-template-changes implemented#10

Open
pallavisarwar wants to merge 2 commits intoHackYourFutureBelgium:mainfrom
pallavisarwar:pallavi-node-template-project
Open

project: node-template-changes implemented#10
pallavisarwar wants to merge 2 commits intoHackYourFutureBelgium:mainfrom
pallavisarwar:pallavi-node-template-project

Conversation

@pallavisarwar
Copy link

No description provided.

@pallavisarwar
Copy link
Author

changes implemented

@maeligg
Copy link
Contributor

maeligg commented Jul 22, 2024

This looks good @pallavisarwar ! A couple of small comments :
I noticed you added some new routes rendering some HTML. This was not strictly necessary for this project but is good practice to test the endpoints ! The only thing I would change is to move these routes into the routes/ directory where to other route handlers are located. Also watch out that both routes are listening for get('/') which means only 1 will get executed when you hit that endpoint. You should use different routes if you want both to be accessible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants