Panel judging opt in #343
Open
Panel judging opt in #343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import judgeStyles from './JudgeAuthForm.module.scss'; | ||
|
|
||
| type Role = 'hacker' | 'judge'; | ||
| type FieldName = 'email' | 'password' | 'passwordDupe' | 'code'; |
There was a problem hiding this comment.
Is there a reason why FieldName is no longer needed?
| cursor: field.readOnly ? 'not-allowed' : 'auto', | ||
| }} | ||
| /> | ||
| {field.type === 'checkbox' ? ( |
There was a problem hiding this comment.
Do you have a frontend example of this? just curious how it looks. Maybe during tmr (10/27) meeting you can briefly share.
| _id?: string; | ||
| track: string; | ||
| domain: string; | ||
| domain?: string; |
There was a problem hiding this comment.
In response to your pr description, yeah I'm not too sure either why "Best Hack for Social Good" doesn't have a domain. It was also not in the admin panel judging view and we had to judge it ourselves last year, not sure if that was intentional - may need to check with Jay or someone last year about that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm fairly sure this works.
I've tested it on the mock data I have from old testing with only tech team as judges and it seemed to work for panel creation (I temporarily removed the limits on how many panels a judge can be on).
Have also added a dropdown to the Admin page for judges to allow changing of panel judging opt in.
I did have to make the 'domain' optional on panels, since the "Best Hack for Social Good" does not have a domain, do not know how this didn't break the panel judging before... but it is something to keep in mind if we run into problems later.
Have not checked the judge check in form part yet.