Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twix panel to save automatic calibration values to the repo #1447

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

tuxbotix
Copy link
Contributor

@tuxbotix tuxbotix commented Sep 16, 2024

Why? What?

Similar functionality to the Manual Calibration panel, subscribes to the additional output from calibration controller and re-use the "save to head" button used elsewhere :) + set-in-nao

  • Also fixed the Roll-Pitch-Yaw labels in the manual panel so that the human doing the tuning can do it as before without getting their brain tangled :P

Left hand side shows the result from calibration and when "set in Nao" is clicked it is synced to the nao (as seen on manual calibration panel) and save to repo will automagically update the right JSON file ;)

image

Fixes #

#1115

TODO/ Known Issues

Ideas for Next Iterations (Not This PR)

  • Add statistics, metrics (i.e. RMSE - root mean square error), etc to the panel (after implementing)
    • Helps to decide if a calibration run is good.

How to Test

Launch twix and open "Automatic camera calibration..." panel. Once calibratiopn process is completed, it should display the values.

@schluis schluis force-pushed the 2024-09_save_automatic_calibration branch from 747a79f to 22f57ff Compare January 11, 2025 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Request for Review
Development

Successfully merging this pull request may close these issues.

1 participant