-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Central gamestate timeing #1006
Merged
Merged
+218
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
883a4a8
to
9af54c6
Compare
2f2eb91
to
f57b892
Compare
7b77005
to
367944e
Compare
oleflb
previously approved these changes
Jun 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks very good, just some weird newlines
crates/spl_network_messages/src/game_controller_state_message.rs
Outdated
Show resolved
Hide resolved
crates/spl_network_messages/src/game_controller_state_message.rs
Outdated
Show resolved
Hide resolved
367944e
to
df897e9
Compare
oleflb
approved these changes
Jul 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
tuxbotix
pushed a commit
to tuxbotix/hulk
that referenced
this pull request
Jul 6, 2024
* central_gamestate_timing * rebase * rebas * add last_filtered_game_controller_state_change to filtered_game_controller_state * rebase * formating * formating die 2te * rebase fixes * fix working now * Format * remove new lines * format --------- Co-authored-by: phillip kammradt <phillip.kammradt@tuhh>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 7, 2024
…n darf II) (#798) * Initial work * All compiles *except* getting the measurements from vision * Make the controller to work * Make the behaviour simulator happy * Capture loop runs. Basic variety supports waiting for look-at. * Fake data format * Cleaner state handling * Got rid of calibration_control crate * Clippyfying * SerializeHierarchy for Measurement * Rename measurement provider * Use naming "CalibrationCommand" * Update last capture command time * WIP * Add missing fake data * Extend timestamp checking to work properly. * Start fake measurement * Switch to center circle candidates and trigger calibration * Additional output for debugging * fix rebase * All Woerks ;) * parametrize all * Change defaults * Remove center circle calibration dependency * Clean unused dependencies * Import cleanups * Fix serialisation mishaps and some other bits * Fix a few more errors * DOn't clone field_dimensions * Review fixes, pass 1 * Woerks * More cleaning * Simplify the vision cycler * Prettier fixes * Fix for re-enabling calibration after finish state * Reorder imports * fix more style issues * Clean up state tracking * destructure instead of match * Simplify calibration command: pass 1 * Simplify calibration command: pass 2 * Cleaned up * Replace From trait with a function that take &self * Reduce visibility * Fix malformed commet * Apply suggestions * Add copy trait * Simplified things * Make the big match smaller * Copy trait changed things * change headmotions for calibration * Central gamestate timeing (#1006) * central_gamestate_timing * rebase * rebas * add last_filtered_game_controller_state_change to filtered_game_controller_state * rebase * formating * formating die 2te * rebase fixes * fix working now * Format * remove new lines * format --------- Co-authored-by: phillip kammradt <phillip.kammradt@tuhh> * Change head motion cases * Use an inner struct to handle changing states * Simplify calibration command -> calibration capture command * Rename calibration command ;) --------- Co-authored-by: JackyBlox <90517319+JackyBloxx@users.noreply.github.com> Co-authored-by: phillip kammradt <phillip.kammradt@tuhh>
oleflb
pushed a commit
to oleflb/hulk
that referenced
this pull request
Jul 15, 2024
* central_gamestate_timing * rebase * rebas * add last_filtered_game_controller_state_change to filtered_game_controller_state * rebase * formating * formating die 2te * rebase fixes * fix working now * Format * remove new lines * format --------- Co-authored-by: phillip kammradt <phillip.kammradt@tuhh>
oleflb
pushed a commit
to oleflb/hulk
that referenced
this pull request
Jul 15, 2024
…n darf II) (HULKs#798) * Initial work * All compiles *except* getting the measurements from vision * Make the controller to work * Make the behaviour simulator happy * Capture loop runs. Basic variety supports waiting for look-at. * Fake data format * Cleaner state handling * Got rid of calibration_control crate * Clippyfying * SerializeHierarchy for Measurement * Rename measurement provider * Use naming "CalibrationCommand" * Update last capture command time * WIP * Add missing fake data * Extend timestamp checking to work properly. * Start fake measurement * Switch to center circle candidates and trigger calibration * Additional output for debugging * fix rebase * All Woerks ;) * parametrize all * Change defaults * Remove center circle calibration dependency * Clean unused dependencies * Import cleanups * Fix serialisation mishaps and some other bits * Fix a few more errors * DOn't clone field_dimensions * Review fixes, pass 1 * Woerks * More cleaning * Simplify the vision cycler * Prettier fixes * Fix for re-enabling calibration after finish state * Reorder imports * fix more style issues * Clean up state tracking * destructure instead of match * Simplify calibration command: pass 1 * Simplify calibration command: pass 2 * Cleaned up * Replace From trait with a function that take &self * Reduce visibility * Fix malformed commet * Apply suggestions * Add copy trait * Simplified things * Make the big match smaller * Copy trait changed things * change headmotions for calibration * Central gamestate timeing (HULKs#1006) * central_gamestate_timing * rebase * rebas * add last_filtered_game_controller_state_change to filtered_game_controller_state * rebase * formating * formating die 2te * rebase fixes * fix working now * Format * remove new lines * format --------- Co-authored-by: phillip kammradt <phillip.kammradt@tuhh> * Change head motion cases * Use an inner struct to handle changing states * Simplify calibration command -> calibration capture command * Rename calibration command ;) --------- Co-authored-by: JackyBlox <90517319+JackyBloxx@users.noreply.github.com> Co-authored-by: phillip kammradt <phillip.kammradt@tuhh>
oleflb
pushed a commit
that referenced
this pull request
Sep 30, 2024
* central_gamestate_timing * rebase * rebas * add last_filtered_game_controller_state_change to filtered_game_controller_state * rebase * formating * formating die 2te * rebase fixes * fix working now * Format * remove new lines * format --------- Co-authored-by: phillip kammradt <phillip.kammradt@tuhh>
oleflb
pushed a commit
that referenced
this pull request
Sep 30, 2024
…n darf II) (#798) * Initial work * All compiles *except* getting the measurements from vision * Make the controller to work * Make the behaviour simulator happy * Capture loop runs. Basic variety supports waiting for look-at. * Fake data format * Cleaner state handling * Got rid of calibration_control crate * Clippyfying * SerializeHierarchy for Measurement * Rename measurement provider * Use naming "CalibrationCommand" * Update last capture command time * WIP * Add missing fake data * Extend timestamp checking to work properly. * Start fake measurement * Switch to center circle candidates and trigger calibration * Additional output for debugging * fix rebase * All Woerks ;) * parametrize all * Change defaults * Remove center circle calibration dependency * Clean unused dependencies * Import cleanups * Fix serialisation mishaps and some other bits * Fix a few more errors * DOn't clone field_dimensions * Review fixes, pass 1 * Woerks * More cleaning * Simplify the vision cycler * Prettier fixes * Fix for re-enabling calibration after finish state * Reorder imports * fix more style issues * Clean up state tracking * destructure instead of match * Simplify calibration command: pass 1 * Simplify calibration command: pass 2 * Cleaned up * Replace From trait with a function that take &self * Reduce visibility * Fix malformed commet * Apply suggestions * Add copy trait * Simplified things * Make the big match smaller * Copy trait changed things * change headmotions for calibration * Central gamestate timeing (#1006) * central_gamestate_timing * rebase * rebas * add last_filtered_game_controller_state_change to filtered_game_controller_state * rebase * formating * formating die 2te * rebase fixes * fix working now * Format * remove new lines * format --------- Co-authored-by: phillip kammradt <phillip.kammradt@tuhh> * Change head motion cases * Use an inner struct to handle changing states * Simplify calibration command -> calibration capture command * Rename calibration command ;) --------- Co-authored-by: JackyBlox <90517319+JackyBloxx@users.noreply.github.com> Co-authored-by: phillip kammradt <phillip.kammradt@tuhh>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced Changes
created an cycler to monitor the last changes in filteredgamestatecontroler
is related to PR #750
Fixes #
ToDo / Known Issues
If this is a WIP describe which problems are to be fixed.
Ideas for Next Iterations (Not This PR)
If there are some improvements that could be done in a next iteration, describe them here.
How to Test
look if the cycler output is right