Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Central gamestate timeing #1006

Merged
merged 12 commits into from
Jul 6, 2024
Merged

Conversation

JackyBloxx
Copy link
Contributor

@JackyBloxx JackyBloxx commented May 9, 2024

Introduced Changes

created an cycler to monitor the last changes in filteredgamestatecontroler
is related to PR #750
Fixes #

ToDo / Known Issues

If this is a WIP describe which problems are to be fixed.

Ideas for Next Iterations (Not This PR)

If there are some improvements that could be done in a next iteration, describe them here.

How to Test

look if the cycler output is right

@JackyBloxx JackyBloxx force-pushed the central_gamestate_timeing branch from 883a4a8 to 9af54c6 Compare May 9, 2024 11:44
@JackyBloxx JackyBloxx assigned JackyBloxx and unassigned JackyBloxx May 9, 2024
@oleflb oleflb added the RC24 label Jun 1, 2024
@JackyBloxx JackyBloxx force-pushed the central_gamestate_timeing branch from 2f2eb91 to f57b892 Compare June 5, 2024 14:22
@JackyBloxx JackyBloxx force-pushed the central_gamestate_timeing branch from 7b77005 to 367944e Compare June 26, 2024 14:15
@JackyBloxx JackyBloxx removed their assignment Jun 26, 2024
oleflb
oleflb previously approved these changes Jun 29, 2024
Copy link
Contributor

@oleflb oleflb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks very good, just some weird newlines

@oleflb oleflb self-assigned this Jun 29, 2024
@JackyBloxx JackyBloxx enabled auto-merge July 3, 2024 11:58
Copy link
Contributor

@oleflb oleflb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@JackyBloxx JackyBloxx added this pull request to the merge queue Jul 6, 2024
Merged via the queue into HULKs:main with commit df0c74a Jul 6, 2024
25 checks passed
@JackyBloxx JackyBloxx deleted the central_gamestate_timeing branch July 6, 2024 15:02
tuxbotix pushed a commit to tuxbotix/hulk that referenced this pull request Jul 6, 2024
* central_gamestate_timing

* rebase

* rebas

* add last_filtered_game_controller_state_change to filtered_game_controller_state

* rebase

* formating

* formating die 2te

* rebase fixes

* fix working now

* Format

* remove new lines

* format

---------

Co-authored-by: phillip kammradt <phillip.kammradt@tuhh>
github-merge-queue bot pushed a commit that referenced this pull request Jul 7, 2024
…n darf II) (#798)

* Initial work

* All compiles *except* getting the measurements from vision

* Make the controller to work

* Make the behaviour simulator happy

* Capture loop runs. Basic variety supports waiting for look-at.

* Fake data format

* Cleaner state handling

* Got rid of calibration_control crate

* Clippyfying

* SerializeHierarchy for Measurement

* Rename measurement provider

* Use naming "CalibrationCommand"

* Update last capture command time

* WIP

* Add missing fake data

* Extend timestamp checking to work properly.

* Start fake measurement

* Switch to center circle candidates and trigger calibration

* Additional output for debugging

* fix rebase

* All Woerks ;)

* parametrize all

* Change defaults

* Remove center circle calibration dependency

* Clean unused dependencies

* Import cleanups

* Fix serialisation mishaps and some other bits

* Fix a few more errors

* DOn't clone field_dimensions

* Review fixes, pass 1

* Woerks

* More cleaning

* Simplify the vision cycler

* Prettier fixes

* Fix for re-enabling calibration after finish state

* Reorder imports

* fix more
style issues

* Clean up state tracking

* destructure instead of match

* Simplify calibration command: pass 1

* Simplify calibration command: pass 2

* Cleaned up

* Replace From trait with a function that take &self

* Reduce visibility

* Fix malformed commet

* Apply suggestions

* Add copy trait

* Simplified things

* Make the big match smaller

* Copy trait changed things

* change headmotions for calibration

* Central gamestate timeing (#1006)

* central_gamestate_timing

* rebase

* rebas

* add last_filtered_game_controller_state_change to filtered_game_controller_state

* rebase

* formating

* formating die 2te

* rebase fixes

* fix working now

* Format

* remove new lines

* format

---------

Co-authored-by: phillip kammradt <phillip.kammradt@tuhh>

* Change head motion cases

* Use an inner struct to handle changing states

* Simplify calibration command -> calibration capture command

* Rename calibration command ;)

---------

Co-authored-by: JackyBlox <90517319+JackyBloxx@users.noreply.github.com>
Co-authored-by: phillip kammradt <phillip.kammradt@tuhh>
oleflb pushed a commit to oleflb/hulk that referenced this pull request Jul 15, 2024
* central_gamestate_timing

* rebase

* rebas

* add last_filtered_game_controller_state_change to filtered_game_controller_state

* rebase

* formating

* formating die 2te

* rebase fixes

* fix working now

* Format

* remove new lines

* format

---------

Co-authored-by: phillip kammradt <phillip.kammradt@tuhh>
oleflb pushed a commit to oleflb/hulk that referenced this pull request Jul 15, 2024
…n darf II) (HULKs#798)

* Initial work

* All compiles *except* getting the measurements from vision

* Make the controller to work

* Make the behaviour simulator happy

* Capture loop runs. Basic variety supports waiting for look-at.

* Fake data format

* Cleaner state handling

* Got rid of calibration_control crate

* Clippyfying

* SerializeHierarchy for Measurement

* Rename measurement provider

* Use naming "CalibrationCommand"

* Update last capture command time

* WIP

* Add missing fake data

* Extend timestamp checking to work properly.

* Start fake measurement

* Switch to center circle candidates and trigger calibration

* Additional output for debugging

* fix rebase

* All Woerks ;)

* parametrize all

* Change defaults

* Remove center circle calibration dependency

* Clean unused dependencies

* Import cleanups

* Fix serialisation mishaps and some other bits

* Fix a few more errors

* DOn't clone field_dimensions

* Review fixes, pass 1

* Woerks

* More cleaning

* Simplify the vision cycler

* Prettier fixes

* Fix for re-enabling calibration after finish state

* Reorder imports

* fix more
style issues

* Clean up state tracking

* destructure instead of match

* Simplify calibration command: pass 1

* Simplify calibration command: pass 2

* Cleaned up

* Replace From trait with a function that take &self

* Reduce visibility

* Fix malformed commet

* Apply suggestions

* Add copy trait

* Simplified things

* Make the big match smaller

* Copy trait changed things

* change headmotions for calibration

* Central gamestate timeing (HULKs#1006)

* central_gamestate_timing

* rebase

* rebas

* add last_filtered_game_controller_state_change to filtered_game_controller_state

* rebase

* formating

* formating die 2te

* rebase fixes

* fix working now

* Format

* remove new lines

* format

---------

Co-authored-by: phillip kammradt <phillip.kammradt@tuhh>

* Change head motion cases

* Use an inner struct to handle changing states

* Simplify calibration command -> calibration capture command

* Rename calibration command ;)

---------

Co-authored-by: JackyBlox <90517319+JackyBloxx@users.noreply.github.com>
Co-authored-by: phillip kammradt <phillip.kammradt@tuhh>
oleflb pushed a commit that referenced this pull request Sep 30, 2024
* central_gamestate_timing

* rebase

* rebas

* add last_filtered_game_controller_state_change to filtered_game_controller_state

* rebase

* formating

* formating die 2te

* rebase fixes

* fix working now

* Format

* remove new lines

* format

---------

Co-authored-by: phillip kammradt <phillip.kammradt@tuhh>
oleflb pushed a commit that referenced this pull request Sep 30, 2024
…n darf II) (#798)

* Initial work

* All compiles *except* getting the measurements from vision

* Make the controller to work

* Make the behaviour simulator happy

* Capture loop runs. Basic variety supports waiting for look-at.

* Fake data format

* Cleaner state handling

* Got rid of calibration_control crate

* Clippyfying

* SerializeHierarchy for Measurement

* Rename measurement provider

* Use naming "CalibrationCommand"

* Update last capture command time

* WIP

* Add missing fake data

* Extend timestamp checking to work properly.

* Start fake measurement

* Switch to center circle candidates and trigger calibration

* Additional output for debugging

* fix rebase

* All Woerks ;)

* parametrize all

* Change defaults

* Remove center circle calibration dependency

* Clean unused dependencies

* Import cleanups

* Fix serialisation mishaps and some other bits

* Fix a few more errors

* DOn't clone field_dimensions

* Review fixes, pass 1

* Woerks

* More cleaning

* Simplify the vision cycler

* Prettier fixes

* Fix for re-enabling calibration after finish state

* Reorder imports

* fix more
style issues

* Clean up state tracking

* destructure instead of match

* Simplify calibration command: pass 1

* Simplify calibration command: pass 2

* Cleaned up

* Replace From trait with a function that take &self

* Reduce visibility

* Fix malformed commet

* Apply suggestions

* Add copy trait

* Simplified things

* Make the big match smaller

* Copy trait changed things

* change headmotions for calibration

* Central gamestate timeing (#1006)

* central_gamestate_timing

* rebase

* rebas

* add last_filtered_game_controller_state_change to filtered_game_controller_state

* rebase

* formating

* formating die 2te

* rebase fixes

* fix working now

* Format

* remove new lines

* format

---------

Co-authored-by: phillip kammradt <phillip.kammradt@tuhh>

* Change head motion cases

* Use an inner struct to handle changing states

* Simplify calibration command -> calibration capture command

* Rename calibration command ;)

---------

Co-authored-by: JackyBlox <90517319+JackyBloxx@users.noreply.github.com>
Co-authored-by: phillip kammradt <phillip.kammradt@tuhh>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants