Skip to content

Conversation

@suvikankare
Copy link
Contributor

@suvikankare suvikankare commented Dec 12, 2025

This change is Reviewable

@suvikankare suvikankare force-pushed the user-table branch 2 times, most recently from 34717b1 to 1d58285 Compare December 12, 2025 09:21
@suvikankare suvikankare marked this pull request as ready for review December 12, 2025 10:47
Copy link
Contributor

@culka culka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@culka reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @suvikankare)


src/main/resources/application.properties line 69 at r1 (raw file):

spring.flyway.schemas[email protected]@
spring.flyway.locations=classpath:db/migration
spring.flyway.placeholders.dbHasuraUsername=${db.hasura.username:@db.hasura.username@}

${ } sisällä : oikealla puolella on oletusarvo jos vasemman puolen arvoa ei löydy. Samaa arvoa ei varmaan molemmille puolille tarvitse.

Copy link
Contributor

@culka culka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@culka reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @suvikankare)

Copy link
Contributor

@culka culka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @suvikankare)


src/main/resources/db/migration/V1__create_login_audit_table.sql line 15 at r2 (raw file):

DO $$
BEGIN
    IF EXISTS (SELECT FROM pg_roles WHERE rolname = 'dbauth') THEN

dbauth pitää korvata myös db.username:n arvolla, koska sekin saattaa muuttua ympäristöstä riippuen.


src/main/resources/db/migration/V1__create_login_audit_table.sql line 19 at r2 (raw file):

        GRANT USAGE, SELECT ON SEQUENCE login_audit_id_seq TO dbauth;
    END IF;
    IF EXISTS (SELECT FROM pg_roles WHERE rolname = '${dbHasuraUsername}') THEN

Olemassaolevaa migraatiota ei voi muokata jos se on viety jo mainiin asti. Tästä pitää tehdä V2 versio jossa on sama muutos. Tämä tiedosto jätetään ennalleen.

Onneksi nämä aiemmin tehdyt oikeuksien antamiset eivät myöskään haittaa mitään, joten ei ole mitään kumottavaa.

Copy link
Contributor Author

@suvikankare suvikankare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 3 of 6 files reviewed, 2 unresolved discussions (waiting on @culka)


src/main/resources/db/migration/V1__create_login_audit_table.sql line 15 at r2 (raw file):

Previously, culka (Teemu Mäkinen) wrote…

dbauth pitää korvata myös db.username:n arvolla, koska sekin saattaa muuttua ympäristöstä riippuen.

Done.


src/main/resources/db/migration/V1__create_login_audit_table.sql line 19 at r2 (raw file):

Previously, culka (Teemu Mäkinen) wrote…

Olemassaolevaa migraatiota ei voi muokata jos se on viety jo mainiin asti. Tästä pitää tehdä V2 versio jossa on sama muutos. Tämä tiedosto jätetään ennalleen.

Onneksi nämä aiemmin tehdyt oikeuksien antamiset eivät myöskään haittaa mitään, joten ei ole mitään kumottavaa.

Done.

Copy link
Contributor

@culka culka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@culka reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @suvikankare)

@suvikankare suvikankare merged commit bda6a0d into main Dec 12, 2025
19 checks passed
@suvikankare suvikankare deleted the user-table branch December 12, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants