-
Notifications
You must be signed in to change notification settings - Fork 0
Read hasura username from secrets #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
34717b1 to
1d58285
Compare
culka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@culka reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @suvikankare)
src/main/resources/application.properties line 69 at r1 (raw file):
spring.flyway.schemas[email protected]@ spring.flyway.locations=classpath:db/migration spring.flyway.placeholders.dbHasuraUsername=${db.hasura.username:@db.hasura.username@}
${ } sisällä : oikealla puolella on oletusarvo jos vasemman puolen arvoa ei löydy. Samaa arvoa ei varmaan molemmille puolille tarvitse.
1d58285 to
5c6cec6
Compare
culka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@culka reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @suvikankare)
culka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @suvikankare)
src/main/resources/db/migration/V1__create_login_audit_table.sql line 15 at r2 (raw file):
DO $$ BEGIN IF EXISTS (SELECT FROM pg_roles WHERE rolname = 'dbauth') THEN
dbauth pitää korvata myös db.username:n arvolla, koska sekin saattaa muuttua ympäristöstä riippuen.
src/main/resources/db/migration/V1__create_login_audit_table.sql line 19 at r2 (raw file):
GRANT USAGE, SELECT ON SEQUENCE login_audit_id_seq TO dbauth; END IF; IF EXISTS (SELECT FROM pg_roles WHERE rolname = '${dbHasuraUsername}') THEN
Olemassaolevaa migraatiota ei voi muokata jos se on viety jo mainiin asti. Tästä pitää tehdä V2 versio jossa on sama muutos. Tämä tiedosto jätetään ennalleen.
Onneksi nämä aiemmin tehdyt oikeuksien antamiset eivät myöskään haittaa mitään, joten ei ole mitään kumottavaa.
5c6cec6 to
3924858
Compare
suvikankare
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 3 of 6 files reviewed, 2 unresolved discussions (waiting on @culka)
src/main/resources/db/migration/V1__create_login_audit_table.sql line 15 at r2 (raw file):
Previously, culka (Teemu Mäkinen) wrote…
dbauthpitää korvata myösdb.username:n arvolla, koska sekin saattaa muuttua ympäristöstä riippuen.
Done.
src/main/resources/db/migration/V1__create_login_audit_table.sql line 19 at r2 (raw file):
Previously, culka (Teemu Mäkinen) wrote…
Olemassaolevaa migraatiota ei voi muokata jos se on viety jo mainiin asti. Tästä pitää tehdä V2 versio jossa on sama muutos. Tämä tiedosto jätetään ennalleen.
Onneksi nämä aiemmin tehdyt oikeuksien antamiset eivät myöskään haittaa mitään, joten ei ole mitään kumottavaa.
Done.
culka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@culka reviewed 3 of 3 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @suvikankare)
This change is