DT-4133 Migrate from momentjs to luxon #5403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjvuor
commented
Jun 3, 2025
There was a problem hiding this comment.
In this component we are creating DateTime objects and mostly formatting them as strings for comparisons. It's debatable if it would be more robust to compare the objects directly.
|
looks good to me. Anyway, maybe we should wait until the next UI release (next wednesday) before merging this many changes. Summer break gives us plenty of time to test the changes in dev. |
tkalvas
requested changes
Jun 16, 2025
app/component/ParkAndRideContent.js
Outdated
| @@ -80,8 +80,12 @@ function ParkAndRideContent( | |||
| if (to - from - 60 * 60 * 24 === 0) { | |||
| return [`24${intl.formatMessage({ id: 'hour-short' })}`]; | |||
| } | |||
| const formattedFrom = moment.utc(from * 1000).format('HH:mm'); | |||
| const formattedTo = moment.utc(to * 1000).format('HH:mm'); | |||
| const formattedFrom = DateTime.fromMillis(from * 1000) | |||
app/component/ParkAndRideContent.js
Outdated
| const formattedFrom = DateTime.fromMillis(from * 1000) | ||
| .toUTC() | ||
| .toFormat('HH:mm'); | ||
| const formattedTo = DateTime.fromMillis(to * 1000) |
app/component/ParkAndRideContent.js
Outdated
| const from = moment.utc(timeSpans.from * 1000).format('HH:mm'); | ||
| const to = moment.utc(timeSpans.to * 1000).format('HH:mm'); | ||
| const day = date.toLocaleString(currentLanguage, { weekday: 'short' }); | ||
| const from = DateTime.fromMillis(timeSpans.from * 1000) |
app/component/ParkAndRideContent.js
Outdated
| const from = DateTime.fromMillis(timeSpans.from * 1000) | ||
| .toUTC() | ||
| .toFormat('HH:mm'); | ||
| const to = DateTime.fromMillis(timeSpans.to * 1000) |
app/constants.js
Outdated
| @@ -66,6 +66,7 @@ export const RealtimeStateType = Object.freeze({ | |||
| * This is the date format string to use for querying dates from OTP. | |||
| */ | |||
| export const DATE_FORMAT = 'YYYYMMDD'; | |||
| export const DATE_FORMAT_LUXON = 'yyyyLLdd'; | |||
There was a problem hiding this comment.
The bare string 'yyyyLLdd' appears in several places, but they could all use the named constant.
app/util/mqttClient.js
Outdated
| @@ -97,7 +97,7 @@ export function parseMessage(topic, message, defaultFeedId) { | |||
| operatingDay: | |||
| parsedMessage.oday && parsedMessage.oday !== 'XXX' | |||
| ? parsedMessage.oday | |||
| : moment().format('YYYY-MM-DD'), | |||
| : DateTime.now().toFormat('yyyy-LL-dd'), | |||
There was a problem hiding this comment.
Actually ALL the date formatting constants could be named and collected in a single place.
tkalvas
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Pull Request Check List
Review