CommunityToolkit/Windows#445 #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x5bfa
reviewed
Sep 30, 2024
| <!-- Sets this up as a toolkit component's source project --> | ||
| <Import Project="$(ToolingDirectory)\ToolkitComponent.SourceProject.props" /> | ||
| <ItemGroup> | ||
| <None Remove="NativeMethods.json" /> |
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "allowMarshaling": false | |||
There was a problem hiding this comment.
Add scheme and preserve sig.
Suggested change
| "allowMarshaling": false | |
| "$schema": "https://aka.ms/CsWin32.schema.json", | |
| "allowMarshaling": false, | |
| "comInterop": { | |
| "preserveSigMethods": [ | |
| "*" | |
| ] | |
| } |
Author
There was a problem hiding this comment.
We only use
RegisterClassEx
DefWindowProc
CreateWindowEx
WM_SETTINGCHANGE
Not a single COM interface gets imported.
So I don't think comInterop.preserveSigMethods is needed.
There was a problem hiding this comment.
Contributors may use com interfaces for other things. There's no reason to keep it out. Also add the schema.
0x5bfa
approved these changes
Sep 30, 2024
0x5bfa
left a comment
0x5bfa
left a comment
There was a problem hiding this comment.
Looks good to me 👍
EOF change in components/Helpers/src/MultiTarget.props may have to be reverted.
Author
|
@HO-COOH I'm gonna leave this to you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix CommunityToolkit#445