-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
将 "Add Java" 的行为更改为选择一个目录后, 在目录中递归搜索并添加所有 Java #3494
Open
ri-fumo
wants to merge
11
commits into
HMCL-dev:main
Choose a base branch
from
ri-fumo:add-java-by-search
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ri-fumo
force-pushed
the
add-java-by-search
branch
from
December 15, 2024 10:51
cea4e8b
to
984761a
Compare
ri-fumo
force-pushed
the
add-java-by-search
branch
from
December 15, 2024 10:59
984761a
to
cd9fe39
Compare
新的代码请尽量使用 java.nio.Path 替换 java.io.File。 |
我不是特别喜欢递归搜索,感觉改成支持多选就可以了 |
递归搜索可以让玩家一次添加多个 Java / 不需要准确选中 java 可执行文件 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3492
如果选择的是某个 Java Home 或 bin 目录, 则认为选择了单个 Java
目录搜索递归层数限制为3层
由于增加按钮会导致过于拥挤, 所以直接更改了 "Add Java" 的行为
另外, i18n 中俄语 西班牙语 日语的翻译可能有误, 需要校正