FHIR-52960 - Require support for GET and POST at authorization endpoint - #30
Open
JohnMoehrke wants to merge 4 commits into
Open
FHIR-52960 - Require support for GET and POST at authorization endpoint#30JohnMoehrke wants to merge 4 commits into
JohnMoehrke wants to merge 4 commits into
Conversation
Collaborator
|
Changes already committed to main branch; looks like we were working on this at the same time. |
Collaborator
Author
|
I do not see this change applied to main. |
Collaborator
Author
|
I see you added POST, but you put it in a section only for authorization code flow. That is not the section the jira ticket agreed to update |
Collaborator
|
This is where it best flowed with the other content. If you think this
is outside of my editorial discretion, I would like to reopen the
ticket. Let me know if this is necessary.
The GET/POST requirement applies for authorization code flow in general. It is unrelated to the 'state' parameter so that section was not the appropriate place to insert it.
|
Collaborator
|
I have created a new ticket as a technical correction FHIR-58224 to fix this. |
Collaborator
Author
|
to be clear... I am not at all questioning your skills and SME. I am just pointing out that the Jira ticket placed the text elsewhere... and where you placed it is limited to authorization code flow (I don't know if that is sufficient). So, I just pushed back to be clear that the change you made was not the one agreed to. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes the IG explicit that Authorization Servers must support both GET and POST requests to the authorization endpoint for the authorization code flow, and that clients must be prepared to use either method.
FHIR-52960