feat: support environment variables in parsers#210
Open
wkpark wants to merge 2 commits intoHKUDS:mainfrom
Open
feat: support environment variables in parsers#210wkpark wants to merge 2 commits intoHKUDS:mainfrom
wkpark wants to merge 2 commits intoHKUDS:mainfrom
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
8bb2237 to
2289578
Compare
Collaborator
|
Thanks for the contribution. One potential regression to consider:
Suggestion:
|
a6cde1f to
69a2d75
Compare
fix: simplified
- Add strict validation for the 'env' parameter to ensure it is a dictionary of strings. - Implement fail-fast behavior in MineruParser for unsupported keyword arguments. - Add a new test for environment propagation and argument validation.
69a2d75 to
ad9ce85
Compare
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
support environment variables in parsers
Checklist
Additional Notes
you can set environment variables for Mineru and Docling.
for example, you can set
CUDA_VISIBLE_DEVICES=1to make the parser run on a specific GPU. This prevents the parser from slowing down your main AI model on the first GPU.