You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When the atexit handler calls close(), the default event loop policy may already be torn down during interpreter shutdown, causing asyncio.run() to raise RuntimeError: There is no current event loop in thread 'MainThread'.
This fix adds a fallback: if asyncio.run() fails, we manually create a new event loop with asyncio.new_event_loop() and run the finalization there. This ensures storages are properly finalized regardless of when the cleanup runs.
I reviewed the change and found two potential issues:
Blocking: RuntimeError handling is too broad in the fallback path
In raganything/raganything.py, the new except RuntimeError: around asyncio.run(self.finalize_storages()) may also catch RuntimeError raised insidefinalize_storages() itself (not only event-loop-policy teardown errors).
That can:
mask the original failure reason,
trigger a second finalize attempt unexpectedly,
make debugging harder.
Non-blocking: manual loop should be set as current loop during fallback
In the new_event_loop() branch, it is safer to call asyncio.set_event_loop(loop) before run_until_complete(...), then clear it with asyncio.set_event_loop(None) in finally.
Some downstream code may still call asyncio.get_event_loop() during finalize; without setting the current loop, fallback can still fail in those cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #135
When the
atexithandler callsclose(), the default event loop policy may already be torn down during interpreter shutdown, causingasyncio.run()to raiseRuntimeError: There is no current event loop in thread 'MainThread'.This fix adds a fallback: if
asyncio.run()fails, we manually create a new event loop withasyncio.new_event_loop()and run the finalization there. This ensures storages are properly finalized regardless of when the cleanup runs.