Clarify in the doc string that elementwise_grad is only applicable to diagonal Jacobians #369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think it's a limitation that is important to point out. Trying to use elementwise_grad for non-diagonal Jacobians will silently return incorrect values. I've copied and modified the doc from some older version of elementwise_grad. The doc could be extended further if there are any other features/limitations to be pointed out for the current version.
agriyakhetarpal
force-pushed
the
master
branch
from
86820fd to
2f6cc22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's a limitation that is important to point out. Trying to use elementwise_grad for non-diagonal Jacobians will silently return incorrect values.
I've copied and modified the doc from some older version of elementwise_grad. The doc could be extended further if there are any other features/limitations to be pointed out for the current version.