Fix/preserve bookmarks incremental sync #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
raohammad
commented
Dec 4, 2025
raohammad
commented
- Capture existing bookmark directly from state before _write_starting_replication_value
- Collect max replication key value only from records that will be synced (filtered by bookmark)
- For incremental syncs, use WHERE clause to filter max collection
- For first sync, collect max from entire table
- Prevents state from resetting to earliest timestamp
- Respects forward-only bookmarks manually set in state
- Only syncs delta instead of re-syncing entire dataset
…1.7.7 and 3.17.4, respectively (MeltanoLabs#66)
- Capture existing bookmark directly from state before _write_starting_replication_value - Collect max replication key value only from records that will be synced (filtered by bookmark) - For incremental syncs, use WHERE clause to filter max collection - For first sync, collect max from entire table - Prevents state from resetting to earliest timestamp - Respects forward-only bookmarks manually set in state - Only syncs delta instead of re-syncing entire dataset
- Disable linting and pytest jobs in CI workflow (not needed for fork) - Disable project_add workflow (for MeltanoLabs org, not needed for HGData)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.