Skip to content

Adapt prior and param-init to forward map#451

Open
LucaMantani wants to merge 3 commits intomainfrom
adapt-prior-forward-map
Open

Adapt prior and param-init to forward map#451
LucaMantani wants to merge 3 commits intomainfrom
adapt-prior-forward-map

Conversation

@LucaMantani
Copy link
Copy Markdown
Member

@LucaMantani LucaMantani commented Apr 30, 2026

This PR adapts the param initialisation to the existence of the forward map and consequently the possible presence of extra parameters.

NOTE: the node doing the parameter initialisation is currently called "pdf_initial_parameters" but now this is a bit of a misnomer since it can be a list of more parameters than just the pdf ones. Maybe we can consider renaming things? Alternatively, we could think of separating into two initialisation, pdf and extra, and then concatenate them.

Extra parameters can be controlled from the runcard in a totally symmetric way to pdf parameters, in addition to specifying their existence in the list extra_param_names:

prior_settings:
  prior_distribution: uniform_parameter_prior
  prior_distribution_specs:
    bounds:
      c1: [-1, 1]
      c2: [-3, 3]

param_initialiser_settings:
    type: uniform
    bounds:
        c1: [-1, 1]
        c2: [-3, 3]

extra_param_names: [c1, c2]

@codacy-production
Copy link
Copy Markdown

codacy-production Bot commented Apr 30, 2026

Up to standards ✅

🟢 Issues 5 high · 1 medium · 2 minor

Results:
8 new issues

Category Results
UnusedCode 1 medium
1 minor
ErrorProne 3 high
Security 2 high
CodeStyle 1 minor

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.36%. Comparing base (4065a3a) to head (23ca96d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #451      +/-   ##
==========================================
- Coverage   96.36%   96.36%   -0.01%     
==========================================
  Files          32       32              
  Lines        1678     1677       -1     
==========================================
- Hits         1617     1616       -1     
  Misses         61       61              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant