Adapt prior and param-init to forward map#451
Open
LucaMantani wants to merge 3 commits intomainfrom
Open
Conversation
Up to standards ✅🟢 Issues
|
| Category | Results |
|---|---|
| UnusedCode | 1 medium 1 minor |
| ErrorProne | 3 high |
| Security | 2 high |
| CodeStyle | 1 minor |
🟢 Metrics 0 complexity · 0 duplication
Metric Results Complexity 0 Duplication 0
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #451 +/- ##
==========================================
- Coverage 96.36% 96.36% -0.01%
==========================================
Files 32 32
Lines 1678 1677 -1
==========================================
- Hits 1617 1616 -1
Misses 61 61 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adapts the param initialisation to the existence of the forward map and consequently the possible presence of extra parameters.
NOTE: the node doing the parameter initialisation is currently called "pdf_initial_parameters" but now this is a bit of a misnomer since it can be a list of more parameters than just the pdf ones. Maybe we can consider renaming things? Alternatively, we could think of separating into two initialisation, pdf and extra, and then concatenate them.
Extra parameters can be controlled from the runcard in a totally symmetric way to pdf parameters, in addition to specifying their existence in the list extra_param_names: