Skip to content

Remove fill_fk_xgrid_with_zeros and ensure masking in convolution#441

Open
comane wants to merge 1 commit intomainfrom
fix_fill_xgrid_w_zeros_bug
Open

Remove fill_fk_xgrid_with_zeros and ensure masking in convolution#441
comane wants to merge 1 commit intomainfrom
fix_fill_xgrid_w_zeros_bug

Conversation

@comane
Copy link
Copy Markdown
Member

@comane comane commented Mar 25, 2026

  • Fix a bug due to wrong zeros filling when using hadronic fk tables
  • removed the need of fill_fk_xgrid_with_zeros in most of the code. fill_fk_xgrid_with_zeros is only needed by fast_kernel_arrays, this might be useful in the case in which we want to stack them over the data-dimension

…d_indices and made sure to always mask when convoluting
@comane comane added bug Something isn't working run-analytic_ct labels Mar 25, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.96%. Comparing base (47ea395) to head (fdf0701).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #441   +/-   ##
=======================================
  Coverage   94.96%   94.96%           
=======================================
  Files          31       31           
  Lines        1649     1650    +1     
=======================================
+ Hits         1566     1567    +1     
  Misses         83       83           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@comane
Copy link
Copy Markdown
Member Author

comane commented Mar 25, 2026

@tgiani I changed this feature which was introduce for stacking purposes for the GP project. Could you check that it does not break anything in your workflow?

@tgiani
Copy link
Copy Markdown
Collaborator

tgiani commented Mar 26, 2026

@comane thanks, I ll look at it in the coming days

Copy link
Copy Markdown
Collaborator

@tgiani tgiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. It doesn t break anything in the gp module

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working run-mcreplica_ct

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants