Remove fill_fk_xgrid_with_zeros and ensure masking in convolution#441
Open
Remove fill_fk_xgrid_with_zeros and ensure masking in convolution#441
Conversation
Member
comane
commented
Mar 25, 2026
- Fix a bug due to wrong zeros filling when using hadronic fk tables
- removed the need of fill_fk_xgrid_with_zeros in most of the code. fill_fk_xgrid_with_zeros is only needed by fast_kernel_arrays, this might be useful in the case in which we want to stack them over the data-dimension
…d_indices and made sure to always mask when convoluting
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #441 +/- ##
=======================================
Coverage 94.96% 94.96%
=======================================
Files 31 31
Lines 1649 1650 +1
=======================================
+ Hits 1566 1567 +1
Misses 83 83 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
@tgiani I changed this feature which was introduce for stacking purposes for the GP project. Could you check that it does not break anything in your workflow? |
Collaborator
|
@comane thanks, I ll look at it in the coming days |
tgiani
approved these changes
Apr 14, 2026
Collaborator
tgiani
left a comment
There was a problem hiding this comment.
Looks good to me. It doesn t break anything in the gp module
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.