Skip to content

Separate forward map#428

Merged
LucaMantani merged 33 commits intomainfrom
separate-forward-map
Apr 30, 2026
Merged

Separate forward map#428
LucaMantani merged 33 commits intomainfrom
separate-forward-map

Conversation

@LucaMantani
Copy link
Copy Markdown
Member

@LucaMantani LucaMantani commented Feb 16, 2026

This PR aims at separating the definition of the forward map from the pdf_model, granting us further flexibility to implement generalisations such as the addition of nuisance parameters or eft Wilson coefficients.

The main changes are:

  • remove pred_and_pdf function
  • Definition of an abstract class ForwardMap, which requires always the implementation of a __call__method with signature (fk_arrays, params) -> predictions, pdf
  • The implementation of a particular case, which is the one we are currently using that does only PDF fitting.
  • Params are all the parameters of interest, and the first n_pdf_params are always assumed to be the pdf ones.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.36%. Comparing base (bad34b4) to head (177898a).
⚠️ Report is 55 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #428      +/-   ##
==========================================
+ Coverage   96.13%   96.36%   +0.23%     
==========================================
  Files          31       32       +1     
  Lines        1654     1678      +24     
==========================================
+ Hits         1590     1617      +27     
+ Misses         64       61       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread colibri/forward_map.py Outdated
Comment thread colibri/checks.py Outdated
@comane comane force-pushed the separate-forward-map branch from 59f1d0c to 1afebf6 Compare March 23, 2026 17:36
Comment thread colibri/forward_map.py Outdated
Comment thread colibri/forward_map.py Outdated
Comment thread colibri/forward_map.py Outdated
@codacy-production
Copy link
Copy Markdown

codacy-production Bot commented Apr 28, 2026

Up to standards ✅

🟢 Issues 35 high · 18 minor

Results:
53 new issues

Category Results
UnusedCode 1 minor
Documentation 17 minor
ErrorProne 5 high
Security 30 high

View in Codacy

🟢 Metrics 43 complexity · 3 duplication

Metric Results
Complexity 43
Duplication 3

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@LucaMantani LucaMantani merged commit 4065a3a into main Apr 30, 2026
7 checks passed
@LucaMantani LucaMantani deleted the separate-forward-map branch April 30, 2026 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants