Implementation of the NTK in Colibri

[achiefa]

This PR implements the Neural Tangent Kernel (NTK) in Colibri. The idea is to compute the NTK for any PDF model that is trained using the Monte Carlo replica method and gradient-based optimisers.

To compute the NTKs, the model parameters are stored on disk during training with a user-specified recording frequency. This will create a new directory called parameters in each replica folder, which will contain the set of parameters for each recorded epoch.

[LucaMantani]

A little comment

[LucaMantani]

Hi @achiefa , thanks for starting this. Just from a quick look, may I suggest to not have this write stuff directly, but rather add things in the GradientDescentResult? This way the writing is delegated to other dedicated functions and you don't need to modify much here. Similarly for the MonteCarloFit class.

[achiefa]

Hi @LucaMantani, thanks for your comment. Indeed, we have considered this option, which I agree has a more solid design principle. However, I was worried that storing the parameters for all recorded epochs could yield memory issues during training. If instead we use a buffer that is saved on disk and freed at the end of each epoch, then we avoid any potential memory issue. Maybe this is not a problem at all, and we can simply store all parameters in a big array and then add it to GradientDescentResult.

Just to quantify the problem: For a neural network with 763 parameters (float64), a single array is about 0.01 MB. This is then multiplied by the number of epochs for which we want to save the parameters. For instance, if we have 100 epochs, this adds up to ~1MB for one replica. Again, probably we can afford this in favour of a better code design. What do you think?

[LucaMantani]

I think 1 MB is nothing, we load in memory several Gb due to the data and FK tables. Even if one had a model with 1000 parameters, saving it 1000 times would be 8 Mb. So I would say memory is far from being an issue?

[achiefa]

I agree. Let's put it in GradientDescentResult then.

[achiefa]

I had to change this directory from colibri/results to NNDF/results because the former is not created when installing Colibri. Is this a bug or a leftover from the previous implementation? @LucaMantani @comane

[codacy-production]

Up to standards ✅

🟢 Issues 3 high · 1 medium · 15 minor

Results:
19 new issues

Category	Results
UnusedCode	1 medium
ErrorProne	2 high
Security	1 high
CodeStyle	15 minor

View in Codacy

🟢 Metrics 256 complexity · 6 duplication

Metric	Results
Complexity	256
Duplication	6

View in Codacy

_{TIP This summary will be updated as you push new changes. Give us feedback}