-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Binomial distribution #101
Conversation
for more information, see https://pre-commit.ci
…s into binomial-dist
for more information, see https://pre-commit.ci
Very nice contribution at first glance, sorry I missed this. I don't get notified by Github when a PR is created, but I get a notification if you ping me explicitly with @HDembinski |
src/numba_stats/binom.py
Outdated
|
||
@_jit(2, cache=False) | ||
def _logpmf(k, n, p): | ||
T = type(n) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you want the type of p here, not n
src/numba_stats/binom.py
Outdated
n : int | ||
number of trails. | ||
p : float | ||
success probability for each trail. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trial
There were a couple of other issues, which I fixed here, that had quite far-reaching ripples into the code.
|
Oh wow, you are right, that's pretty cool! |
Source code is inspired by the scipy implementation.