#64 Add explicit metadata for synthetic-only fixture assumptions FIXED - #84
Merged
knytcomics-ui merged 1 commit intoAug 24, 2026
Conversation
Add explicit metadata for synthetic-only fixture assumptions FIXED
Contributor
Author
|
@knytcomics-ui PLS maintainer when you are done reviewing ,pls when you get the chance pls issue payment via grantfox as this will encourage me to keep on contributing ....thank you |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a required per-destination
fixture_statusfield to distinguish synthetic-only fixtures from future network-visible fixtures. All existing destinations are marked assynthetic-only, and validation now rejects missing or unknown status values. This prevents consumers from interpreting synthetic fixture labels as live Horizon truth.Type of change
Changelog
[Unreleased]inCHANGELOG.mddescribing what changed and why.Briefly summarise the changelog entry here:
Added the required per-fixture
fixture_statusfield and marked all existing destinations assynthetic-only. No destination scores were changed.Score-regression guard
CHANGELOG.md.Validation
npm run validatepasses locally.Additional test result:
Validation result:
Related issues
Resolves the per-destination fixture lifecycle status issue described in this PR.
Horizon lookups were not added, in accordance with the issue scope.
CLOSE #64