Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix translation issue on boolean_field and revert some code that is s… #224

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

fedegl
Copy link
Collaborator

@fedegl fedegl commented Jun 16, 2022

…till needed

# Convinience method to launch a link within a modal.
# Appends the data-action="modal#open" to trigger the ModalController
#
def link_to_modal(name, options = nil, html_options = nil, &block)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 2 locations. Consider refactoring.

# Convinience method to launch a link within a drawer.
# Appends the data-action="drawer#open" to trigger the DrawerController
#
def link_to_drawer(name, options = nil, html_options = nil, &block)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 2 locations. Consider refactoring.

@codeclimate
Copy link

codeclimate bot commented Jun 17, 2022

Code Climate has analyzed commit d70f574 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

The test coverage on the diff in this pull request is 12.5% (50% is the threshold).

This pull request will bring the total coverage in the repository to 45.2% (-0.7% change).

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant