Skip to content

Fix: Preserve Scientific Name Attributes on Crop Edit #4379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
google-labs-jules wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

Fix: Preserve Scientific Name Attributes on Crop Edit #4379

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion app/controllers/crops_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,15 @@ def notify_wranglers
def recreate_names(param_name, name_type)
return if params[param_name].blank?

# Get the submitted names, reject blanks, and sort for comparison
submitted_names = params[param_name].values.reject(&:blank?).sort
# Get the existing names from the database, and sort for comparison
existing_names = @crop.send("#{name_type}_names").pluck(:name).sort

# Return early to prevent destroying and recreating names (and their associated attributes)
# if the list of names has not changed.
return if submitted_names == existing_names

@crop.send("#{name_type}_names").each(&:destroy)
params[param_name].each_value do |value|
next if value.empty?
Expand All @@ -226,7 +235,7 @@ def crop_params
:public_food_key,
:row_spacing, :spread, :height,
:sowing_method, :sun_requirements, :growing_degree_days,
scientific_names_attributes: %i(scientific_name _destroy id)
scientific_names_attributes: %i(name _destroy id)
)
end

Expand Down
Loading