-
Notifications
You must be signed in to change notification settings - Fork 215
Add table for weather observation (Stacked PR) #3452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
CloCkWeRX
wants to merge
20
commits into
dev
Choose a base branch
from
add-garden-attributes
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 7 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
bbd8c94
Add table for weather
CloCkWeRX 5ef4ca3
Timestamps
CloCkWeRX 3087443
Merge branch 'rubocop-todo' into add-garden-attributes
CloCkWeRX 8ee0881
Rubocop
CloCkWeRX d0e3a8f
Add model
CloCkWeRX 7ed0d0d
Validations
CloCkWeRX 99d5b08
Merge branch 'dev' into add-garden-attributes
CloCkWeRX 4596698
Fix warning
CloCkWeRX e9ec6f2
Fix warning
CloCkWeRX dee6000
Fix warning
CloCkWeRX 775986d
Fix validators
CloCkWeRX a081a8d
Fix warnings
CloCkWeRX a4cfb60
Put observations at the owner level, rather than a specific garden
CloCkWeRX fca91a0
Put observations at the owner level, rather than a specific garden
CloCkWeRX bc08964
Add placehlder views
CloCkWeRX 02a3776
Merge branch 'dev' into add-garden-attributes
CloCkWeRX ead197a
Add schema
CloCkWeRX 699fdb8
Merge branch 'dev' into add-garden-attributes
CloCkWeRX 703c119
Merge branch 'dev' into add-garden-attributes
CloCkWeRX 49a248e
Merge branch 'dev' into add-garden-attributes
CloCkWeRX File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| # A weather observation is intended to be a snapshot aligned to | ||
| # https://github.com/schemaorg/schemaorg/issues/362 | ||
| class WeatherObservation < ApplicationRecord | ||
| belongs_to :garden | ||
|
|
||
| validates :source, presence: true | ||
| validates :observed_at, presence: true | ||
|
|
||
| # Lowest temp on earth: -89.2°C (-128.6°F) | ||
| # Highest: 56.7°C | ||
| validates :dew_point_temperature_centigrade, min: -90, max: 60 | ||
| validates :air_temperature_centigrade, min: -90, max: 60 | ||
| validates :relative_humidity, min: 0, max: 100 | ||
| validates :wind_speed_kmh, min: 0, max: 450 # Highest 408 km/h | ||
| validates :wind_gust_speed_kmh, min: 0, max: 450 # Highest 408 km/h | ||
| end | ||
CloCkWeRX marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| class AddWeatherObservations < ActiveRecord::Migration[7.0] | ||
| def change | ||
| # See https://github.com/schemaorg/schemaorg/issues/362 | ||
| create_table :weather_observations do |t| | ||
| t.string :source | ||
| t.datetime :observation_at | ||
| t.integer :solar_uv_index | ||
| t.decimal :wind_speed_kmh | ||
| t.decimal :wind_gust_speed_kmh | ||
| t.string :wind_direction | ||
| t.decimal :air_temperature_centigrade | ||
| t.decimal :relative_humidity | ||
| t.decimal :precipitation_probability | ||
| t.decimal :dew_point_temperature_centigrade | ||
| t.decimal :pressure | ||
| t.integer :visibility_distance_metres | ||
| t.string :weather_type | ||
| t.references :garden_id | ||
| t.timestamps | ||
| end | ||
| end | ||
| end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.