-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve fastbreak verbose message #1851
base: 2.0
Are you sure you want to change the base?
Conversation
use consistent case, include the target block type
Co-authored-by: ManInMyVan <[email protected]>
Co-authored-by: ManInMyVan <[email protected]>
@ManInMyVan It would be good to have a standardized verbose format (space and = separated, camel case), I did plan this but I decided against it because people (including myself) are already parsing the verbose and I don't want to break existing setups. |
majority of checks use |
I wonder if allowing inputting verbose as a |
If I made a PR overhauling verbose using map instead and adding more descriptive verbose to every check, do you think you would merge it? |
verbose should still allow string input
these should be seperate prs
I can't merge prs |
@ManInMyVan rebased |
@@ -27,8 +28,11 @@ public FastBreak(GrimPlayer playerData) { | |||
|
|||
// The block the player is currently breaking | |||
Vector3i targetBlock = null; | |||
|
|||
// The material of block the player is currently breaking | |||
StateType targetType = null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FastBreak gets handled before updating the block, you don't need to track the block type, you can use blockBreak.block.getType()
Co-authored-by: ManInMyVan <[email protected]>
Status? |
use consistent case, include the target block type