Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove config name #1838

Open
wants to merge 1 commit into
base: 2.0
Choose a base branch
from
Open

remove config name #1838

wants to merge 1 commit into from

Conversation

ManInMyVan
Copy link
Contributor

@ManInMyVan ManInMyVan commented Nov 29, 2024 •
edited
Loading

they shouldn't be different imo.

@SamB440 SamB440 added the status: review required The pull request is awaiting review label Dec 1, 2024
@ManInMyVan ManInMyVan force-pushed the remove-configname branch 2 times, most recently from 16f598a to 9d00e5f Compare December 13, 2024 19:46
@Axionize
Copy link
Contributor

If your check has a space or - in its name I can see differently. I feel like sane behavior is to default to the name field but allow overriding the configName.

@ManInMyVan ManInMyVan added the status: rebase required The pull request needs rebasing onto the merge branch label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: rebase required The pull request needs rebasing onto the merge branch status: review required The pull request is awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ManInMyVan @Axionize @SamB440