Checks command #1705
Draft
Checks command #1705
+440
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anthony01M
suggested changes
Sep 10, 2024
src/main/java/ac/grim/grimac/manager/init/start/CommandRegister.java
Outdated
Show resolved
Hide resolved
ManInMyVan
reviewed
Sep 10, 2024
src/main/java/ac/grim/grimac/checks/impl/movement/NegativeTimerCheck.java
Outdated
Show resolved
Hide resolved
src/main/java/ac/grim/grimac/checks/impl/velocity/ExplosionHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/ac/grim/grimac/manager/init/start/CommandRegister.java
Outdated
Show resolved
Hide resolved
|
@ManInMyVan @Anthony01M could you guys check if everything is okay? |
ManInMyVan
reviewed
Sep 10, 2024
ManInMyVan
reviewed
Sep 10, 2024
ManInMyVan
reviewed
Sep 26, 2024
|
Will this be merged? |
|
@overkidding can you fix the merge conflicts? Why hasn't this been merged yet? |
ManInMyVan
requested changes
Nov 25, 2024
src/main/java/ac/grim/grimac/checks/impl/prediction/DebugHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/ac/grim/grimac/checks/impl/groundspoof/NoFallA.java
Outdated
Show resolved
Hide resolved
src/main/java/ac/grim/grimac/checks/impl/scaffolding/DuplicateRotPlace.java
Outdated
Show resolved
Hide resolved
SamB440
added
the
status: rebase required
|
Rebase and apply MIMV's suggestions and I'll merge it. |
Done |
ManInMyVan
requested changes
Dec 2, 2024
SamB440
added
status: review required
ManInMyVan
added
the
status: rebase required
ManInMyVan
requested changes
Feb 23, 2025
| @@ -33,6 +33,8 @@ public class Check implements AbstractCheck, ConfigReloadObserver { | |||
| private boolean isEnabled; | |||
| private boolean exempted; | |||
|
|
|||
| private CheckType type; | |||
There was a problem hiding this comment.
this should be added in AbstractCheck so API users can access it, and so that custom checks can be included in /grim checks
Translations have been made with ChatGPT so could be inaccurate.
… ACF, use one string instead of sending everyline
overkidding
force-pushed
the
checks-cmd-pr
branch
from
e14d5ed to
b60f7b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #1704
Translations have been made with ChatGPT so could be inaccurate.