allow configuring reach flag buffer #1683
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reach basically never falses, why does it need a buffer? |
This was already a thing, this just makes it configurable |
|
We need a unified buffer system that's just in every check regardless instead of having to create one every time for a check that needs one. Might port the one from 3.0 to 2.0 unless someone makes a good PR for one. |
ManInMyVan
force-pushed
the
configurable-reach
branch
2 times, most recently
from
9d4db86 to
1fe5112
Compare
ManInMyVan
force-pushed
the
configurable-reach
branch
from
1fe5112 to
481b3ce
Compare
ManInMyVan
added
the
status: rebase required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.