Add Breaking Checks

[ManInMyVan]

How can I compensate tick skipping in fastbreak?

[Souipi]

Why add your own checks that can be bypassed in 10 minutes? It would be better to fix a broken simulation.

Actually the prediction engine is just impossible to fix without breaking other things

[Dg32z]

farbreak false when player tping

[ManInMyVan]

farbreak false when player tping

What's "d" and "m"?

[Dg32z]

Farbreak False 当玩家传送

什么是“d”和“m”？

I just changed Verbose to its abbreviation, the fact is

[to LiquidAirBreak](/GrimAnticheat/Grim/pull/1639/commits/cc540b6a8272ff92a30f7b68a245b30e8114adf7)
[cc540b6](/GrimAnticheat/Grim/pull/1639/commits/cc540b6a8272ff92a30f7b68a245b30e8114adf7)

[Add breaking checks to punishments.yml](/GrimAnticheat/Grim/pull/1639/commits/e09930d1ef4419a180623ea6de6512fed2f512ec)
[e09930d](/GrimAnticheat/Grim/pull/1639/commits/e09930d1ef4419a180623ea6de6512fed2f512ec)

[Fix PositionBreakA check name](/GrimAnticheat/Grim/pull/1639/commits/35247bba77e3217aeb0d74197cc574f148610aee)
[35247bb](/GrimAnticheat/Grim/pull/1639/commits/35247bba77e3217aeb0d74197cc574f148610aee)
ManInMyVan force-pushed the breaking-checks branch from ad6c7d9 to 35247bb Compare September 2, 2024 04:30
ManInMyVan added 9 commits September 1, 2024 17:01

[rewrite fastbreak](/GrimAnticheat/Grim/pull/1639/commits/fc4e868aa40e8a488bc3c081aea23c6a8df9d1d9) …
[fc4e868](/GrimAnticheat/Grim/pull/1639/commits/fc4e868aa40e8a488bc3c081aea23c6a8df9d1d9)

[make BlockBreakCheck an interface](/GrimAnticheat/Grim/pull/1639/commits/038496268cc31c881b32ad74a394973caaacc362)
[0384962](/GrimAnticheat/Grim/pull/1639/commits/038496268cc31c881b32ad74a394973caaacc362)

[add FarBreak](/GrimAnticheat/Grim/pull/1639/commits/b174affd9a701348b714776f18a96434462d6599)
[b174aff](/GrimAnticheat/Grim/pull/1639/commits/b174affd9a701348b714776f18a96434462d6599)

[WrongBlock -> WrongBreak](/GrimAnticheat/Grim/pull/1639/commits/ad644f7b1473f2abd2a92888a5eb328e58b8f2d1)
[ad644f7](/GrimAnticheat/Grim/pull/1639/commits/ad644f7b1473f2abd2a92888a5eb328e58b8f2d1)

[don't require implementing onBlockBreak](/GrimAnticheat/Grim/pull/1639/commits/fef3bd5b6e8608a64199950e12850dc422ab3d8e)
[fef3bd5](/GrimAnticheat/Grim/pull/1639/commits/fef3bd5b6e8608a64199950e12850dc422ab3d8e)

[fix some falses in vehicles](/GrimAnticheat/Grim/pull/1639/commits/5c854047c08edb08a6b25c95ddc2e001995bc845)
[5c85404](/GrimAnticheat/Grim/pull/1639/commits/5c854047c08edb08a6b25c95ddc2e001995bc845)

[fix some more falses](/GrimAnticheat/Grim/pull/1639/commits/8de56753fef4fedca433335fc2faf373a495e0e2)
[8de5675](/GrimAnticheat/Grim/pull/1639/commits/8de56753fef4fedca433335fc2faf373a495e0e2)

[Add RotationBreak](/GrimAnticheat/Grim/pull/1639/commits/1f077722d532e1aec3de1db35af5261990fbf2e9)
[1f07772](/GrimAnticheat/Grim/pull/1639/commits/1f077722d532e1aec3de1db35af5261990fbf2e9)

[Add NoSwingBreak](/GrimAnticheat/Grim/pull/1639/commits/009422d0d02ea0c1220025e4c1c4ed1ebd0da3e3)
[009422d](/GrimAnticheat/Grim/pull/1639/commits/009422d0d02ea0c1220025e4c1c4ed1ebd0da3e3)
ManInMyVan force-pushed the breaking-checks branch from af717b2 to

I just changed Verbose to its abbreviation, the fact is if (flagAndAlert("d= " + Math.sqrt(min) + "\nm= " + maxReach) && shouldModifyPackets()) {

[Dg32z]

In version 1.8 of the server, org.bukkit.block.data.BlockData does not exist, causing players to be kicked when start resyncPosition

[ManInMyVan]

In version 1.8 of the server, org.bukkit.block.data.BlockData does not exist, causing players to be kicked when start resyncPosition

it shouldn't be using BlockData unless the server is 1.13+

I wonder if it's getting UNKNOWN as the server version

[Axionize]

If you're still struggling to account for tick skipping have you considered calling your method everytime the client ticks reliably, and if your check runs and the client hasn't been ticking reliable, to just give the client the maximum possible uncertainty within the time since the last break and current time as uncertainty?

[DimaSergeew]

That’s a solid suggestion! Even though I'm not a coder, it sounds like a great approach to handle tick skipping. Adjusting uncertainty based on time difference could really help with more accurate detection. I agree, it's worth testing out!

[Axionize]

Besides your ray trace check (FastBreakB) giving extra uncertainty to 1.8 players when they don't need it, I see nothing wrong? Are there any known issues still plaguing this check?

[ManInMyVan]

giving extra uncertainty to 1.8 players when they don't need it

Where

[Axionize]

In FastBreakB you expand eyePositions by eyePositions.expand(player.getMovementThreshold()); whereas in PositionBreakA you expand by !player.packetStateData.didLastMovementIncludePosition || player.getClientVersion().isNewerThanOrEquals(ClientVersion.V_1_9) ? player.getMovementThreshold() : 0. Is there any particular reason you expand by the later in PositionBreakA but by the former in FastBreakB?

[ManInMyVan]

In FastBreakB you expand eyePositions by eyePositions.expand(player.getMovementThreshold()); whereas in PositionBreakA you expand by !player.packetStateData.didLastMovementIncludePosition || player.getClientVersion().isNewerThanOrEquals(ClientVersion.V_1_9) ? player.getMovementThreshold() : 0. Is there any particular reason you expand by the later in PositionBreakA but by the former in FastBreakB?

I just copied it from rotationplace