Open
Conversation
havogt
commented
Mar 25, 2026
havogt
commented
Mar 25, 2026
|
|
||
| def assert_close(expected, actual): | ||
| assert math.isclose(expected, actual), "expected={}, actual={}".format(expected, actual) | ||
| assert np.allclose(expected, actual), "expected={}, actual={}".format(expected, actual) |
Contributor
Author
There was a problem hiding this comment.
the new numpy version returns a 1d array with 1 element in the reduction that is passed to this function.
havogt
commented
Mar 25, 2026
| # to test typing with gt4py in downstream code | ||
| {include-group = "typing"}, | ||
| 'types-six', # can not let mypy auto-install types as that leads to unexpected stderr output (which means test failure) | ||
| 'pytest-mypy-plugins', # pytest plugin for running mypy on code snippets |
Contributor
Author
There was a problem hiding this comment.
see change in noxfile
DropD
requested changes
Mar 26, 2026
Contributor
DropD
left a comment
DropD
left a comment
There was a problem hiding this comment.
Drop the flag, because the new default behavior is what we want.
Co-authored-by: Rico Haeuselmann <r.haeuselmann@gmx.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.