fix[cartesian]: Support for data dims of size one in dace backends#2547
Merged
romanc merged 2 commits intoGridTools:mainfrom Mar 24, 2026
Merged
fix[cartesian]: Support for data dims of size one in dace backends#2547romanc merged 2 commits intoGridTools:mainfrom
romanc merged 2 commits intoGridTools:mainfrom
Conversation
This PR fixes an issue in the dace backends. Access of data dimensions with size one would generate invalid SDFGs. In case an array has size one, there's only one value, so the only valid way to access array `a` is `a[0]`. When accessed inside a `Tasklet`, this access is already fully defined in the Memlet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue in the dace backends, where accesses of data dimensions with size one would generate invalid SDFGs. In case an array has size one, there's only one value, so the only valid way to access array
aisa[0]. When accessed inside aTasklet, this access is already fully defined in the Memlet. We were - in addition - adding a slice inside theTaskletleading to an attempted slice of a scalar and thus an invalid SDFG.This issue was detected by Charles in the larger work of GF, where there's an array with sizes
[__I, __J, 1].Requirements
N/A