fix[cartesian]: loop reordering in schedule tree#2546
Open
romanc wants to merge 6 commits intoGridTools:mainfrom
Open
fix[cartesian]: loop reordering in schedule tree#2546romanc wants to merge 6 commits intoGridTools:mainfrom
romanc wants to merge 6 commits intoGridTools:mainfrom
Conversation
romanc
force-pushed
the
romanc/fix-k-loop-flipping
branch
from
10f824c to
c1a3422
Compare
3 tasks
This comment was marked as outdated.
This comment was marked as outdated.
romanc
force-pushed
the
romanc/fix-k-loop-flipping
branch
from
9b4fb61 to
b266249
Compare
This commit updates the DaCe dependency to bring fixes from DaCe mainline. In particular, this brings a fix to InlineSDFG, which would insert a race condition under certain conditions.
romanc
force-pushed
the
romanc/fix-k-loop-flipping
branch
from
b266249 to
5e611ed
Compare
romanc
changed the title
Contributor
Author
|
cscs-ci run |
2 similar comments
Contributor
|
cscs-ci run |
Contributor
Author
|
cscs-ci run |
Contributor
Author
|
I forgot to push the dace changes to our branch on the gt4py org that's maybe why the test keep failing, though it doesn't really make sense that only the AMD tests are rebuilding (and failing to rebuild) the image ... |
Contributor
Author
|
cscs-ci run |
FlorianDeconinck
approved these changes
Mar 27, 2026
Contributor
FlorianDeconinck
left a comment
FlorianDeconinck
left a comment
There was a problem hiding this comment.
LGTM
cscs-ci dies on ROCM image build, unrelated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the loop reordering in the schedule tree. Loop reordering is used as part of the automatic adaption to different memory layouts. The current implementation would run into issues when re-ordering sequential vertical loops (e.g.
with computation(FORWARD)orwith computation(BACKWARD)).In addition, this PR updates the DaCe dependency to include fixes from mainline DaCe; namely a fix to
InlineSDFG, which was found to insert race conditions in certain cases.Together, the fixes in this PR stabilize/validate the remapping translate test with different loop/memory layouts.
Requirements
N/A